Fix wrong copy of encryption 'usage' string

[PATCH 0/2] Fix wrong copy of encryption 'usage' string

Peter Krempa posted 2 patches 4 years, 1 month ago

Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1584636370.git.pkrempa@redhat.com

src/util/virsecret.c            | 3 +--
src/util/virsecret.h            | 4 ++--
src/util/virstorageencryption.c | 8 +++-----
src/util/virstoragefile.c       | 3 +--
4 files changed, 7 insertions(+), 11 deletions(-)

Expand all Fold all

[PATCH 0/2] Fix wrong copy of encryption 'usage' string

Posted by Peter Krempa 4 years, 1 month ago

Copying the pointer caused double-free when clearing the domain object.

Peter Krempa (2):
  virSecretLookupDefCopy: Remove return value
  virStorageEncryptionSecretCopy: Properly copy internals

 src/util/virsecret.c            | 3 +--
 src/util/virsecret.h            | 4 ++--
 src/util/virstorageencryption.c | 8 +++-----
 src/util/virstoragefile.c       | 3 +--
 4 files changed, 7 insertions(+), 11 deletions(-)

-- 
2.24.1

Re: [PATCH 0/2] Fix wrong copy of encryption 'usage' string

Posted by Michal Prívozník 4 years, 1 month ago

On 19. 3. 2020 17:48, Peter Krempa wrote:
> Copying the pointer caused double-free when clearing the domain object.
> 
> Peter Krempa (2):
>   virSecretLookupDefCopy: Remove return value
>   virStorageEncryptionSecretCopy: Properly copy internals
> 
>  src/util/virsecret.c            | 3 +--
>  src/util/virsecret.h            | 4 ++--
>  src/util/virstorageencryption.c | 8 +++-----
>  src/util/virstoragefile.c       | 3 +--
>  4 files changed, 7 insertions(+), 11 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal

Re: [PATCH 0/2] Fix wrong copy of encryption 'usage' string

Posted by Ján Tomko 4 years, 1 month ago

On a Thursday in 2020, Peter Krempa wrote:
>Copying the pointer caused double-free when clearing the domain object.
>
>Peter Krempa (2):
>  virSecretLookupDefCopy: Remove return value
>  virStorageEncryptionSecretCopy: Properly copy internals
>
> src/util/virsecret.c            | 3 +--
> src/util/virsecret.h            | 4 ++--
> src/util/virstorageencryption.c | 8 +++-----
> src/util/virstoragefile.c       | 3 +--
> 4 files changed, 7 insertions(+), 11 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano