qemu: Fix usage of 'slice' and 'luks'

[PATCH 0/4] qemu: Fix usage of 'slice' and 'luks'

Peter Krempa posted 4 patches 4 years, 1 month ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1584635655.git.pkrempa@redhat.com

Test syntax-check failed

src/qemu/qemu_block.c                         | 70 ++++++++++++++-----
src/qemu/qemu_block.h                         |  3 +
src/qemu/qemu_domain.c                        |  3 +-
.../disk-slices.x86_64-latest.args            | 41 +++++++----
tests/qemuxml2argvdata/disk-slices.xml        | 13 ++++
.../disk-slices.x86_64-latest.xml             | 16 ++++-
6 files changed, 112 insertions(+), 34 deletions(-)

Expand all Fold all

[PATCH 0/4] qemu: Fix usage of 'slice' and 'luks'

Posted by Peter Krempa 4 years, 1 month ago

We special cased some behaviour and it broke on combination with other
special case.

Peter Krempa (4):
  qemuxml2argvdata/disk-slices: Add test case for 'luks' encryption
  qemu: block: Extract logic decision when to use a separate 'raw' layer
    for slice
  qemuBlockStorageSourceNeedsStorageSliceLayer: Deal with 'luks' files
  qemu: block: Split up formatting of JSON props for 'raw' and 'luks'
    drivers

 src/qemu/qemu_block.c                         | 70 ++++++++++++++-----
 src/qemu/qemu_block.h                         |  3 +
 src/qemu/qemu_domain.c                        |  3 +-
 .../disk-slices.x86_64-latest.args            | 41 +++++++----
 tests/qemuxml2argvdata/disk-slices.xml        | 13 ++++
 .../disk-slices.x86_64-latest.xml             | 16 ++++-
 6 files changed, 112 insertions(+), 34 deletions(-)

-- 
2.24.1

Re: [PATCH 0/4] qemu: Fix usage of 'slice' and 'luks'

Posted by Ján Tomko 4 years, 1 month ago

On a Thursday in 2020, Peter Krempa wrote:
>We special cased some behaviour and it broke on combination with other
>special case.
>
>Peter Krempa (4):
>  qemuxml2argvdata/disk-slices: Add test case for 'luks' encryption
>  qemu: block: Extract logic decision when to use a separate 'raw' layer
>    for slice
>  qemuBlockStorageSourceNeedsStorageSliceLayer: Deal with 'luks' files
>  qemu: block: Split up formatting of JSON props for 'raw' and 'luks'
>    drivers
>
> src/qemu/qemu_block.c                         | 70 ++++++++++++++-----
> src/qemu/qemu_block.h                         |  3 +
> src/qemu/qemu_domain.c                        |  3 +-
> .../disk-slices.x86_64-latest.args            | 41 +++++++----
> tests/qemuxml2argvdata/disk-slices.xml        | 13 ++++
> .../disk-slices.x86_64-latest.xml             | 16 ++++-
> 6 files changed, 112 insertions(+), 34 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano