qemu: Don't log spurious errors on qemuMonitorDelObject

[PATCH 0/5] qemu: Don't log spurious errors on qemuMonitorDelObject

Peter Krempa posted 5 patches 4 years, 1 month ago

Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1584531508.git.pkrempa@redhat.com

src/qemu/qemu_block.c        | 10 ++---
src/qemu/qemu_driver.c       |  2 +-
src/qemu/qemu_hotplug.c      | 34 +++++++++-------
src/qemu/qemu_monitor.c      |  5 ++-
src/qemu/qemu_monitor.h      |  3 +-
src/qemu/qemu_monitor_json.c | 77 ++++++++++++++++++------------------
src/qemu/qemu_monitor_json.h |  3 +-
7 files changed, 71 insertions(+), 63 deletions(-)

Expand all Fold all

[PATCH 0/5] qemu: Don't log spurious errors on qemuMonitorDelObject

Posted by Peter Krempa 4 years, 1 month ago

qemuMonitorDelObject is often used in cleanup cases so we need to
control whether to log errors.

First patch actually prevents one of the spurious calls in cases we know
it would be pointless.

Peter Krempa (5):
  qemuDomainChangeEjectableMedia: Don't always remove managed PR daemon
  qemuMonitorJSON(Add|Del)Object: Refactor cleanup
  qemuMonitorJSONCheckError: Use g_autofree
  qemuMonitorJSONCheckError: Allow suppressing of error reporting
  qemu: Suppress error reporting from qemuMonitorDelObject in cleanup
    paths

 src/qemu/qemu_block.c        | 10 ++---
 src/qemu/qemu_driver.c       |  2 +-
 src/qemu/qemu_hotplug.c      | 34 +++++++++-------
 src/qemu/qemu_monitor.c      |  5 ++-
 src/qemu/qemu_monitor.h      |  3 +-
 src/qemu/qemu_monitor_json.c | 77 ++++++++++++++++++------------------
 src/qemu/qemu_monitor_json.h |  3 +-
 7 files changed, 71 insertions(+), 63 deletions(-)

-- 
2.24.1

Re: [PATCH 0/5] qemu: Don't log spurious errors on qemuMonitorDelObject

Posted by Michal Prívozník 4 years, 1 month ago

On 18. 3. 2020 12:40, Peter Krempa wrote:
> qemuMonitorDelObject is often used in cleanup cases so we need to
> control whether to log errors.
> 
> First patch actually prevents one of the spurious calls in cases we know
> it would be pointless.
> 
> Peter Krempa (5):
>   qemuDomainChangeEjectableMedia: Don't always remove managed PR daemon
>   qemuMonitorJSON(Add|Del)Object: Refactor cleanup
>   qemuMonitorJSONCheckError: Use g_autofree
>   qemuMonitorJSONCheckError: Allow suppressing of error reporting
>   qemu: Suppress error reporting from qemuMonitorDelObject in cleanup
>     paths
> 
>  src/qemu/qemu_block.c        | 10 ++---
>  src/qemu/qemu_driver.c       |  2 +-
>  src/qemu/qemu_hotplug.c      | 34 +++++++++-------
>  src/qemu/qemu_monitor.c      |  5 ++-
>  src/qemu/qemu_monitor.h      |  3 +-
>  src/qemu/qemu_monitor_json.c | 77 ++++++++++++++++++------------------
>  src/qemu/qemu_monitor_json.h |  3 +-
>  7 files changed, 71 insertions(+), 63 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal