[PATCH 0/3] cleanups inspired by QMP-deprecation-introspection

Peter Krempa posted 3 patches 4 years, 1 month ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1583331259.git.pkrempa@redhat.com
src/admin/admin_server_dispatch.c             |   3 -
src/locking/lock_daemon.c                     |   8 +-
src/logging/log_daemon.c                      |   8 +-
src/logging/log_handler.c                     |   5 -
src/qemu/qemu_agent.c                         |   8 +-
src/qemu/qemu_command.c                       |   3 +-
src/qemu/qemu_firmware.c                      |  20 +-
src/qemu/qemu_migration_params.c              |   8 +-
src/qemu/qemu_monitor_json.c                  |  53 +--
src/qemu/qemu_vhost_user.c                    |   3 +-
src/rpc/virnetdaemon.c                        |  10 +-
src/rpc/virnetserver.c                        |   5 +-
src/rpc/virnetserverclient.c                  |   3 -
src/rpc/virnetserverservice.c                 |   3 -
src/rpc/virnetsocket.c                        |   3 +-
src/util/virjson.c                            |  21 +-
src/util/virlease.c                           |   6 +-
src/util/virlockspace.c                       |   6 -
src/util/virmacmap.c                          |   5 +-
src/util/virnetdev.c                          |   3 +-
tests/qemuhotplugtest.c                       |   2 +
.../ppc64-modern-bulk-monitor.json            | 390 +++++++++---------
.../ppc64-modern-individual-monitor.json      | 196 ++++-----
.../x86-modern-bulk-monitor.json              | 150 +++----
.../x86-modern-individual-add-monitor.json    |  92 ++---
.../x86-old-bulk-monitor.json                 | 150 +++----
tests/qemumonitortestutils.c                  |   8 +-
27 files changed, 529 insertions(+), 643 deletions(-)
[PATCH 0/3] cleanups inspired by QMP-deprecation-introspection
Posted by Peter Krempa 4 years, 1 month ago
I take a look at Markus' QMP deprecation-introspection series. While
that requires a lot more work I've fixed a few things along.

Peter Krempa (3):
  util: json: Convert virJSONValueNewObject() to g_new0
  qemuMonitorJSONSetMigrationParams: Refactor command construction and
    cleanup
  qemuhotplugtestcpus: Always use 'query-cpus-fast'

 src/admin/admin_server_dispatch.c             |   3 -
 src/locking/lock_daemon.c                     |   8 +-
 src/logging/log_daemon.c                      |   8 +-
 src/logging/log_handler.c                     |   5 -
 src/qemu/qemu_agent.c                         |   8 +-
 src/qemu/qemu_command.c                       |   3 +-
 src/qemu/qemu_firmware.c                      |  20 +-
 src/qemu/qemu_migration_params.c              |   8 +-
 src/qemu/qemu_monitor_json.c                  |  53 +--
 src/qemu/qemu_vhost_user.c                    |   3 +-
 src/rpc/virnetdaemon.c                        |  10 +-
 src/rpc/virnetserver.c                        |   5 +-
 src/rpc/virnetserverclient.c                  |   3 -
 src/rpc/virnetserverservice.c                 |   3 -
 src/rpc/virnetsocket.c                        |   3 +-
 src/util/virjson.c                            |  21 +-
 src/util/virlease.c                           |   6 +-
 src/util/virlockspace.c                       |   6 -
 src/util/virmacmap.c                          |   5 +-
 src/util/virnetdev.c                          |   3 +-
 tests/qemuhotplugtest.c                       |   2 +
 .../ppc64-modern-bulk-monitor.json            | 390 +++++++++---------
 .../ppc64-modern-individual-monitor.json      | 196 ++++-----
 .../x86-modern-bulk-monitor.json              | 150 +++----
 .../x86-modern-individual-add-monitor.json    |  92 ++---
 .../x86-old-bulk-monitor.json                 | 150 +++----
 tests/qemumonitortestutils.c                  |   8 +-
 27 files changed, 529 insertions(+), 643 deletions(-)

-- 
2.24.1

Re: [PATCH 0/3] cleanups inspired by QMP-deprecation-introspection
Posted by Daniel Henrique Barboza 4 years, 1 month ago

On 3/4/20 11:16 AM, Peter Krempa wrote:
> I take a look at Markus' QMP deprecation-introspection series. While
> that requires a lot more work I've fixed a few things along.
> 
> Peter Krempa (3):
>    util: json: Convert virJSONValueNewObject() to g_new0
>    qemuMonitorJSONSetMigrationParams: Refactor command construction and
>      cleanup
>    qemuhotplugtestcpus: Always use 'query-cpus-fast'


Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>