Re-think stance towards image format probing

[PATCH v2 0/3] Re-think stance towards image format probing

Peter Krempa posted 3 patches 4 years, 2 months ago

Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1582635160.git.pkrempa@redhat.com

docs/kbase/backing_chains.rst | 16 +++++++++--
src/qemu/qemu_domain.c        |  4 +++
src/util/virstoragefile.c     | 52 ++++++++++++++++++++---------------
3 files changed, 48 insertions(+), 24 deletions(-)

Expand all Fold all

[PATCH v2 0/3] Re-think stance towards image format probing

Posted by Peter Krempa 4 years, 2 months ago

We decided that use of qemu-img would not be possible for this case. I'm
thus re-sending the patch with fixes to docs and the ISO image format
probe.

This approach is the simplest and most straightforward and deals with
most cases. Specifically we don't have to fix half of blockjob code by
doing this as opposed if we wanted to have qemu open the image itself by
looking into the overlay's metadata.

Peter Krempa (3):
  qemu: domain: Convert detected 'iso' image format into 'raw'
  virStorageFileGetMetadataRecurse: Allow format probing under special
    circumstances
  kbase: backing_chains: Clarify some aspects of image probing

 docs/kbase/backing_chains.rst | 16 +++++++++--
 src/qemu/qemu_domain.c        |  4 +++
 src/util/virstoragefile.c     | 52 ++++++++++++++++++++---------------
 3 files changed, 48 insertions(+), 24 deletions(-)

-- 
2.24.1