Remove usage of virHexToBin (glib chronicles)

[libvirt PATCH 0/3] Remove usage of virHexToBin (glib chronicles)

Ján Tomko posted 3 patches 4 years, 1 month ago

Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1582489237.git.jtomko@redhat.com

src/libvirt_private.syms |  1 -
src/util/virbitmap.c     |  3 +--
src/util/virmacaddr.c    |  5 ++---
src/util/virutil.c       | 15 ---------------
src/util/virutil.h       |  2 --
src/util/viruuid.c       | 11 +++++------
src/vmx/vmx.c            |  4 ++--
7 files changed, 10 insertions(+), 31 deletions(-)

Expand all Fold all

[libvirt PATCH 0/3] Remove usage of virHexToBin (glib chronicles)

Posted by Ján Tomko 4 years, 1 month ago

Prefer g_ascii_xdigit_value

Ján Tomko (3):
  util: uuid: remove use of virHexToBin
  Remove all use of virHexToBin
  util: remove virHexToBin

 src/libvirt_private.syms |  1 -
 src/util/virbitmap.c     |  3 +--
 src/util/virmacaddr.c    |  5 ++---
 src/util/virutil.c       | 15 ---------------
 src/util/virutil.h       |  2 --
 src/util/viruuid.c       | 11 +++++------
 src/vmx/vmx.c            |  4 ++--
 7 files changed, 10 insertions(+), 31 deletions(-)

-- 
2.24.1

Re: [libvirt PATCH 0/3] Remove usage of virHexToBin (glib chronicles)

Posted by Laine Stump 4 years, 1 month ago

On 2/23/20 3:20 PM, Ján Tomko wrote:
> Prefer g_ascii_xdigit_value
>
> Ján Tomko (3):
>    util: uuid: remove use of virHexToBin
>    Remove all use of virHexToBin
>    util: remove virHexToBin
>
>   src/libvirt_private.syms |  1 -
>   src/util/virbitmap.c     |  3 +--
>   src/util/virmacaddr.c    |  5 ++---
>   src/util/virutil.c       | 15 ---------------
>   src/util/virutil.h       |  2 --
>   src/util/viruuid.c       | 11 +++++------
>   src/vmx/vmx.c            |  4 ++--
>   7 files changed, 10 insertions(+), 31 deletions(-)
>

Hmmpph. I meant to respond to 0/3 with my


Reviewed-by: Laine Stump <laine@redhat.com>


not just to the first patch.