tests: libxl: clean up test mocking

[libvirt PATCH 0/7] tests: libxl: clean up test mocking

Ján Tomko posted 7 patches 5 years, 11 months ago

Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1582381502.git.jtomko@redhat.com

src/libxl/libxl_capabilities.h |  3 +-
src/libxl/libxl_conf.c         | 85 ++++++++++++++++++----------------
src/libxl/libxl_conf.h         |  2 +
src/libxl/libxl_driver.c       |  7 +--
tests/Makefile.am              |  9 ++--
tests/libxlmock.c              | 18 +++----
tests/testutilsxen.c           |  9 +++-
7 files changed, 75 insertions(+), 58 deletions(-)

Expand all Fold all

[libvirt PATCH 0/7] tests: libxl: clean up test mocking

Posted by Ján Tomko 5 years, 11 months ago

Refactor libxlDriverConfigNew to remove the need
for mocking virFilePath and add libxlDomainGetEmulatorType
to the mock to remove the need to invoke a binary
for nearly every domain we parse

Ján Tomko (7):
  testutilsxen: error out on initialization failure
  libxl: conf: move default keepalive settings to libxlDriverConfigNew
  libxl: StateInitialize: use g_autofree
  libxl: split out DriverConfigInit out of DriverConfigNew
  libxl: do not mock virFileMakePath
  tests: link the libxl tests with libxltestdriver.la
  tests: libxl: do not run the emulator

 src/libxl/libxl_capabilities.h |  3 +-
 src/libxl/libxl_conf.c         | 85 ++++++++++++++++++----------------
 src/libxl/libxl_conf.h         |  2 +
 src/libxl/libxl_driver.c       |  7 +--
 tests/Makefile.am              |  9 ++--
 tests/libxlmock.c              | 18 +++----
 tests/testutilsxen.c           |  9 +++-
 7 files changed, 75 insertions(+), 58 deletions(-)

-- 
2.24.1

Re: [libvirt PATCH 0/7] tests: libxl: clean up test mocking

Posted by Jim Fehlig 5 years, 11 months ago

On 2/22/20 7:25 AM, Ján Tomko wrote:
> Refactor libxlDriverConfigNew to remove the need
> for mocking virFilePath and add libxlDomainGetEmulatorType
> to the mock to remove the need to invoke a binary
> for nearly every domain we parse
> 
> Ján Tomko (7):
>    testutilsxen: error out on initialization failure
>    libxl: conf: move default keepalive settings to libxlDriverConfigNew
>    libxl: StateInitialize: use g_autofree
>    libxl: split out DriverConfigInit out of DriverConfigNew
>    libxl: do not mock virFileMakePath
>    tests: link the libxl tests with libxltestdriver.la
>    tests: libxl: do not run the emulator
> 
>   src/libxl/libxl_capabilities.h |  3 +-
>   src/libxl/libxl_conf.c         | 85 ++++++++++++++++++----------------
>   src/libxl/libxl_conf.h         |  2 +
>   src/libxl/libxl_driver.c       |  7 +--
>   tests/Makefile.am              |  9 ++--
>   tests/libxlmock.c              | 18 +++----
>   tests/testutilsxen.c           |  9 +++-
>   7 files changed, 75 insertions(+), 58 deletions(-)
> 

For the series

Reviewed-by: Jim Fehlig <jfehlig@suse.com>

Regards,
Jim