[PATCH 1/7] tests: virstorage: Fix backing file format of created image

Peter Krempa posted 7 patches 5 years, 11 months ago
[PATCH 1/7] tests: virstorage: Fix backing file format of created image
Posted by Peter Krempa 5 years, 11 months ago
We create some images for testing our code. We've recorded wrong format
of the backing file for one of the images though.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 tests/virstoragetest.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/virstoragetest.c b/tests/virstoragetest.c
index 39040bf4cb..e7794d6168 100644
--- a/tests/virstoragetest.c
+++ b/tests/virstoragetest.c
@@ -964,7 +964,7 @@ mymain(void)
     /* Rewrite wrap and qcow2 back to 3-deep chain, absolute backing */
     virCommandFree(cmd);
     cmd = virCommandNewArgList(qemuimg, "rebase", "-u", "-f", "qcow2",
-                               "-F", "qcow2", "-b", absraw, "qcow2", NULL);
+                               "-F", "raw", "-b", absraw, "qcow2", NULL);
     if (virCommandRun(cmd, NULL) < 0)
         ret = -1;

-- 
2.24.1

Re: [PATCH 1/7] tests: virstorage: Fix backing file format of created image
Posted by Ján Tomko 5 years, 11 months ago
On Fri, Feb 21, 2020 at 02:51:39PM +0100, Peter Krempa wrote:
>We create some images for testing our code. We've recorded wrong format
>of the backing file for one of the images though.
>
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> tests/virstoragetest.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano