virshtest: remove virTestCaptureProgramOutput

[libvirt PATCH 0/7] virshtest: remove virTestCaptureProgramOutput

Ján Tomko posted 7 patches 4 years, 2 months ago

Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1581211907.git.jtomko@redhat.com

tests/testutils.c | 171 +++++++++-------------------------------------
tests/testutils.h |   2 -
tests/virshtest.c |  35 ++++++----
3 files changed, 54 insertions(+), 154 deletions(-)

Expand all Fold all

[libvirt PATCH 0/7] virshtest: remove virTestCaptureProgramOutput

Posted by Ján Tomko 4 years, 2 months ago

Use virCommand instead of open-coding it and do some other cleanups
found along the way.

Ján Tomko (7):
  testutils: check return value of g_setenv
  testutils: use g_autofree
  testutils: use g_autoptr
  testutils: remove unnecessary labels
  virshtest: refactor testCompareOutputLit
  virshtest: use virCommand instead of custom impl
  testutils: remove now unused virTestCaptureProgramOutput

 tests/testutils.c | 171 +++++++++-------------------------------------
 tests/testutils.h |   2 -
 tests/virshtest.c |  35 ++++++----
 3 files changed, 54 insertions(+), 154 deletions(-)

-- 
2.21.1

Re: [libvirt PATCH 0/7] virshtest: remove virTestCaptureProgramOutput

Posted by Daniel P. Berrangé 4 years, 2 months ago

On Sun, Feb 09, 2020 at 02:32:30AM +0100, Ján Tomko wrote:
> Use virCommand instead of open-coding it and do some other cleanups
> found along the way.

Ohh, great, I thought about this when I did the FreeBSD mass close
patch, but didn't fancy tackling it myself yet.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|