qemu: Properly support 'volume' type backing stores

[PATCH 2/9] virDomainDiskAddISCSIPoolSourceHost: use g_new0 instead of VIR_ALLOC_N

Posted by Peter Krempa 6 years ago

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/conf/domain_conf.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 6124c7520c..7cf555596f 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -31339,9 +31339,7 @@ virDomainDiskAddISCSIPoolSourceHost(virDomainDiskDefPtr def,

     /* iscsi pool only supports one host */
     def->src->nhosts = 1;
-
-    if (VIR_ALLOC_N(def->src->hosts, def->src->nhosts) < 0)
-        goto cleanup;
+    def->src->hosts = g_new0(virStorageNetHostDef, 1);

     def->src->hosts[0].name = g_strdup(pooldef->source.hosts[0].name);

-- 
2.24.1

Re: [PATCH 2/9] virDomainDiskAddISCSIPoolSourceHost: use g_new0 instead of VIR_ALLOC_N

Posted by Ján Tomko 6 years ago

On Wed, Feb 05, 2020 at 02:40:53PM +0100, Peter Krempa wrote:
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> src/conf/domain_conf.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano