1. Patchew
  2. Libvirt
  3. [PATCH v3 0/3] Couple of apparmor fixes
  4. View patch

[PATCH v3 2/3] apparmor: Allow libvirt to spawn virt-aa-helper and libvirt_lxc

Michal Privoznik posted 3 patches 6 years ago
[PATCH v3 2/3] apparmor: Allow libvirt to spawn virt-aa-helper and libvirt_lxc
Posted by Michal Privoznik 6 years ago 
Both of these binaries are spawn by libvirt. Add a rule to the
default profile to allow that.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 src/security/apparmor/usr.sbin.libvirtd.in | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/security/apparmor/usr.sbin.libvirtd.in b/src/security/apparmor/usr.sbin.libvirtd.in
index f4fc51d705..c950a83db8 100644
--- a/src/security/apparmor/usr.sbin.libvirtd.in
+++ b/src/security/apparmor/usr.sbin.libvirtd.in
@@ -99,6 +99,8 @@ profile libvirtd @sbindir@/libvirtd flags=(attach_disconnected) {
   audit deny /sys/kernel/security/apparmor/.* rwxl,
   /sys/kernel/security/apparmor/profiles r,
   @libexecdir@/* puxr,
+  @libexecdir@/virt-aa-helper PUxr,
+  @libexecdir@/libvirt_lxc PUxr,
   @libexecdir@/libvirt_parthelper ix,
   @libexecdir@/libvirt_iohelper ix,
   /etc/libvirt/hooks/** rmix,
-- 
2.24.1
Re: [PATCH v3 2/3] apparmor: Allow libvirt to spawn virt-aa-helper and libvirt_lxc
Posted by Daniel P. Berrangé 6 years ago 
On Thu, Jan 30, 2020 at 03:12:31PM +0100, Michal Privoznik wrote:
> Both of these binaries are spawn by libvirt. Add a rule to the
> default profile to allow that.
> 
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
>  src/security/apparmor/usr.sbin.libvirtd.in | 2 ++
>  1 file changed, 2 insertions(+)

> 
> diff --git a/src/security/apparmor/usr.sbin.libvirtd.in b/src/security/apparmor/usr.sbin.libvirtd.in
> index f4fc51d705..c950a83db8 100644
> --- a/src/security/apparmor/usr.sbin.libvirtd.in
> +++ b/src/security/apparmor/usr.sbin.libvirtd.in
> @@ -99,6 +99,8 @@ profile libvirtd @sbindir@/libvirtd flags=(attach_disconnected) {
>    audit deny /sys/kernel/security/apparmor/.* rwxl,
>    /sys/kernel/security/apparmor/profiles r,
>    @libexecdir@/* puxr,
> +  @libexecdir@/virt-aa-helper PUxr,

I'm really puzzelled about this one. If this was required, then surely
apparmor has been broken since day 1 this was introduced to libvirt ?

Can anyone explain why we've been able todo with this rule forever ?

> +  @libexecdir@/libvirt_lxc PUxr,

I can understand a little more why this might be missing, as it is
not so common as QEMU usage.

>    @libexecdir@/libvirt_parthelper ix,
>    @libexecdir@/libvirt_iohelper ix,
>    /etc/libvirt/hooks/** rmix,
> -- 
> 2.24.1
> 

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
Re: [PATCH v3 2/3] apparmor: Allow libvirt to spawn virt-aa-helper and libvirt_lxc
Posted by Jim Fehlig 6 years ago 
On 2/3/20 9:50 AM, Daniel P. Berrangé wrote:
> On Thu, Jan 30, 2020 at 03:12:31PM +0100, Michal Privoznik wrote:
>> Both of these binaries are spawn by libvirt. Add a rule to the
>> default profile to allow that.
>>
>> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
>> ---
>>   src/security/apparmor/usr.sbin.libvirtd.in | 2 ++
>>   1 file changed, 2 insertions(+)
> 
>>
>> diff --git a/src/security/apparmor/usr.sbin.libvirtd.in b/src/security/apparmor/usr.sbin.libvirtd.in
>> index f4fc51d705..c950a83db8 100644
>> --- a/src/security/apparmor/usr.sbin.libvirtd.in
>> +++ b/src/security/apparmor/usr.sbin.libvirtd.in
>> @@ -99,6 +99,8 @@ profile libvirtd @sbindir@/libvirtd flags=(attach_disconnected) {
>>     audit deny /sys/kernel/security/apparmor/.* rwxl,
>>     /sys/kernel/security/apparmor/profiles r,
>>     @libexecdir@/* puxr,
>> +  @libexecdir@/virt-aa-helper PUxr,
> 
> I'm really puzzelled about this one. If this was required, then surely
> apparmor has been broken since day 1 this was introduced to libvirt ?
> 
> Can anyone explain why we've been able todo with this rule forever ?

Doesn't the rule directly above (which should have PUxr access modes) allow 
spawning virt-aa-helper? Perhaps the explicit rule is only needed if changing 
the access modes from the "default"?

Regards,
Jim
Re: [PATCH v3 2/3] apparmor: Allow libvirt to spawn virt-aa-helper and libvirt_lxc
Posted by Michal Privoznik 6 years ago 
On 2/3/20 5:50 PM, Daniel P. Berrangé wrote:
> On Thu, Jan 30, 2020 at 03:12:31PM +0100, Michal Privoznik wrote:
>> Both of these binaries are spawn by libvirt. Add a rule to the
>> default profile to allow that.
>>
>> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
>> ---
>>   src/security/apparmor/usr.sbin.libvirtd.in | 2 ++
>>   1 file changed, 2 insertions(+)
> 
>>
>> diff --git a/src/security/apparmor/usr.sbin.libvirtd.in b/src/security/apparmor/usr.sbin.libvirtd.in
>> index f4fc51d705..c950a83db8 100644
>> --- a/src/security/apparmor/usr.sbin.libvirtd.in
>> +++ b/src/security/apparmor/usr.sbin.libvirtd.in
>> @@ -99,6 +99,8 @@ profile libvirtd @sbindir@/libvirtd flags=(attach_disconnected) {
>>     audit deny /sys/kernel/security/apparmor/.* rwxl,
>>     /sys/kernel/security/apparmor/profiles r,
>>     @libexecdir@/* puxr,
>> +  @libexecdir@/virt-aa-helper PUxr,
> 
> I'm really puzzelled about this one. If this was required, then surely
> apparmor has been broken since day 1 this was introduced to libvirt ?
> 
> Can anyone explain why we've been able todo with this rule forever ?
> 
>> +  @libexecdir@/libvirt_lxc PUxr,
> 
> I can understand a little more why this might be missing, as it is
> not so common as QEMU usage.

Frankly, I don't understand that too. I just copied what was in the 
gentoo patch. But I can drop this one. The @libexecdir@/* rule should 
allow what is needed anyway.

Michal
Re: [PATCH v3 2/3] apparmor: Allow libvirt to spawn virt-aa-helper and libvirt_lxc
Posted by Daniel P. Berrangé 6 years ago 
On Tue, Feb 04, 2020 at 10:24:07AM +0100, Michal Privoznik wrote:
> On 2/3/20 5:50 PM, Daniel P. Berrangé wrote:
> > On Thu, Jan 30, 2020 at 03:12:31PM +0100, Michal Privoznik wrote:
> > > Both of these binaries are spawn by libvirt. Add a rule to the
> > > default profile to allow that.
> > > 
> > > Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> > > ---
> > >   src/security/apparmor/usr.sbin.libvirtd.in | 2 ++
> > >   1 file changed, 2 insertions(+)
> > 
> > > 
> > > diff --git a/src/security/apparmor/usr.sbin.libvirtd.in b/src/security/apparmor/usr.sbin.libvirtd.in
> > > index f4fc51d705..c950a83db8 100644
> > > --- a/src/security/apparmor/usr.sbin.libvirtd.in
> > > +++ b/src/security/apparmor/usr.sbin.libvirtd.in
> > > @@ -99,6 +99,8 @@ profile libvirtd @sbindir@/libvirtd flags=(attach_disconnected) {
> > >     audit deny /sys/kernel/security/apparmor/.* rwxl,
> > >     /sys/kernel/security/apparmor/profiles r,
> > >     @libexecdir@/* puxr,
> > > +  @libexecdir@/virt-aa-helper PUxr,
> > 
> > I'm really puzzelled about this one. If this was required, then surely
> > apparmor has been broken since day 1 this was introduced to libvirt ?
> > 
> > Can anyone explain why we've been able todo with this rule forever ?
> > 
> > > +  @libexecdir@/libvirt_lxc PUxr,
> > 
> > I can understand a little more why this might be missing, as it is
> > not so common as QEMU usage.
> 
> Frankly, I don't understand that too. I just copied what was in the gentoo
> patch. But I can drop this one. The @libexecdir@/* rule should allow what is
> needed anyway.

Actually, if anything, it probably makes more sense to drop the
generic @libexecdir@ rule, as it allows libvirtd to run anything
under /usr/libexec which makes the policy pretty useless IMHO.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.