util: hash: Aid in debugging of duplicate keys

[PATCH 0/2] util: hash: Aid in debugging of duplicate keys

Peter Krempa posted 2 patches 4 years, 10 months ago

Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1579185232.git.pkrempa@redhat.com

src/conf/domain_addr.c |  9 +++++++++
src/util/vircgroup.c   |  8 ++++++++
src/util/virhash.c     | 22 ++++++++++++++++++++--
src/util/virhash.h     | 13 +++++++++++++
tests/virhashtest.c    | 23 +++++++++++++++++++++++
5 files changed, 73 insertions(+), 2 deletions(-)

Expand all Fold all

[PATCH 0/2] util: hash: Aid in debugging of duplicate keys

Posted by Peter Krempa 4 years, 10 months ago

See patch 1 for rationale.

Peter Krempa (2):
  util: hash: Improve debugability of "Duplicate key" error message
  tests: hash: Test case for adding duplicate hash entry

 src/conf/domain_addr.c |  9 +++++++++
 src/util/vircgroup.c   |  8 ++++++++
 src/util/virhash.c     | 22 ++++++++++++++++++++--
 src/util/virhash.h     | 13 +++++++++++++
 tests/virhashtest.c    | 23 +++++++++++++++++++++++
 5 files changed, 73 insertions(+), 2 deletions(-)

-- 
2.24.1

Re: [PATCH 0/2] util: hash: Aid in debugging of duplicate keys

Posted by Michal Privoznik 4 years, 10 months ago

On 1/16/20 3:34 PM, Peter Krempa wrote:
> See patch 1 for rationale.
> 
> Peter Krempa (2):
>    util: hash: Improve debugability of "Duplicate key" error message
>    tests: hash: Test case for adding duplicate hash entry
> 
>   src/conf/domain_addr.c |  9 +++++++++
>   src/util/vircgroup.c   |  8 ++++++++
>   src/util/virhash.c     | 22 ++++++++++++++++++++--
>   src/util/virhash.h     | 13 +++++++++++++
>   tests/virhashtest.c    | 23 +++++++++++++++++++++++
>   5 files changed, 73 insertions(+), 2 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal

Re: [PATCH 0/2] util: hash: Aid in debugging of duplicate keys

Posted by Peter Krempa 4 years, 10 months ago

On Thu, Jan 16, 2020 at 15:34:29 +0100, Peter Krempa wrote:
> See patch 1 for rationale.
> 
> Peter Krempa (2):
>   util: hash: Improve debugability of "Duplicate key" error message
>   tests: hash: Test case for adding duplicate hash entry

Ping? https://bugzilla.redhat.com/show_bug.cgi?id=1791790 demonstrates
the new error message and how much more helpful than the current state
it is.