[libvirt] [PATCH v2 09/12] autogen.sh: fix autoreconf step

Pavel Hrdina posted 12 patches 4 years, 10 months ago
Only 11 patches received!
[libvirt] [PATCH v2 09/12] autogen.sh: fix autoreconf step
Posted by Pavel Hrdina 4 years, 10 months ago
Running bootstrap and autoreconf from autogen.sh produced different
files in build-aux directory.  The reason is that gnulib usually have
newer version of these files and overwrites them after the autoreconf
step.

In order to fix it remove the --install and --force options, in addition
introduce --verbose option in order to reflect what bootstrap is doing.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
---
 autogen.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/autogen.sh b/autogen.sh
index a1f1943adb..47446dc785 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -134,7 +134,7 @@ if test -d .git || test -f .git; then
         # dry run, of course...
         if test -z "$dry_run"; then
             echo "Running autoreconf..."
-            autoreconf -if || {
+            autoreconf -v || {
                 die "autoreconf failed"
             }
         fi
-- 
2.24.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 09/12] autogen.sh: fix autoreconf step
Posted by Daniel P. Berrangé 4 years, 10 months ago
On Thu, Jan 09, 2020 at 03:53:19PM +0100, Pavel Hrdina wrote:
> Running bootstrap and autoreconf from autogen.sh produced different
> files in build-aux directory.  The reason is that gnulib usually have
> newer version of these files and overwrites them after the autoreconf
> step.
> 
> In order to fix it remove the --install and --force options, in addition
> introduce --verbose option in order to reflect what bootstrap is doing.
> 
> Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
> ---
>  autogen.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list