[libvirt] [PATCH v2 02/12] configure.ac: add check for getegid function

Pavel Hrdina posted 12 patches 4 years, 10 months ago
Only 11 patches received!
[libvirt] [PATCH v2 02/12] configure.ac: add check for getegid function
Posted by Pavel Hrdina 4 years, 10 months ago
We already use this function and so far we've been lucky that the same
check is done by gnulib.  This will change once we will drop gnulib and
also make it obvious that we have to do the same check in Meson as well.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
---
 configure.ac | 1 +
 1 file changed, 1 insertion(+)

diff --git a/configure.ac b/configure.ac
index 002a3dcdb0..cbfb3fe1aa 100644
--- a/configure.ac
+++ b/configure.ac
@@ -355,6 +355,7 @@ dnl and various less common threadsafe functions
 AC_CHECK_FUNCS_ONCE([\
   cfmakeraw \
   fallocate \
+  getegid \
   geteuid \
   getgid \
   getifaddrs \
-- 
2.24.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 02/12] configure.ac: add check for getegid function
Posted by Daniel P. Berrangé 4 years, 10 months ago
On Thu, Jan 09, 2020 at 03:53:12PM +0100, Pavel Hrdina wrote:
> We already use this function and so far we've been lucky that the same
> check is done by gnulib.  This will change once we will drop gnulib and
> also make it obvious that we have to do the same check in Meson as well.
> 
> Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
> ---
>  configure.ac | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list