[libvirt] [PATCH v4 0/5] Introduce flags to virDomainGetHostname()

Michal Privoznik posted 5 patches 2 weeks ago
Test syntax-check failed
Failed in applying to current master (apply log)
docs/manpages/virsh.rst          |   7 +-
include/libvirt/libvirt-domain.h |   6 ++
include/libvirt/virterror.h      |   1 +
scripts/apibuild.py              |   6 ++
src/libvirt-domain.c             |   9 ++-
src/lxc/lxc_driver.c             |  79 +++++++++++++++++++
src/qemu/qemu_driver.c           | 125 +++++++++++++++++++++++++++----
src/remote/remote_daemon.c       |   1 +
src/util/virerror.c              |   7 +-
tools/virsh-completer-domain.c   |  19 +++++
tools/virsh-completer-domain.h   |   4 +
tools/virsh-domain.c             |  37 ++++++++-
tools/virsh-domain.h             |   8 ++
13 files changed, 286 insertions(+), 23 deletions(-)

[libvirt] [PATCH v4 0/5] Introduce flags to virDomainGetHostname()

Posted by Michal Privoznik 2 weeks ago
v4 of:

https://www.redhat.com/archives/libvir-list/2019-December/msg01453.html

diff to v3:
- I've split Julio's one patch into 4 smaller ones,
- I've fixed issues I've raised in v3, like new error code (patch 1/5 is
  completely new that's why I'm authoring it), fixed the completer and
  some memleaks.

Julio Faracco (4):
  Introduce source flags to virDomainGetHostname()
  qemu: Implement virDomainGetHostnameFlags
  lxc: Implement virDomainGetHostnameFlags
  virsh: Expose virDomainGetHostnameFlags

Michal Prívozník (1):
  virerror: Make it easier to add new error number

 docs/manpages/virsh.rst          |   7 +-
 include/libvirt/libvirt-domain.h |   6 ++
 include/libvirt/virterror.h      |   1 +
 scripts/apibuild.py              |   6 ++
 src/libvirt-domain.c             |   9 ++-
 src/lxc/lxc_driver.c             |  79 +++++++++++++++++++
 src/qemu/qemu_driver.c           | 125 +++++++++++++++++++++++++++----
 src/remote/remote_daemon.c       |   1 +
 src/util/virerror.c              |   7 +-
 tools/virsh-completer-domain.c   |  19 +++++
 tools/virsh-completer-domain.h   |   4 +
 tools/virsh-domain.c             |  37 ++++++++-
 tools/virsh-domain.h             |   8 ++
 13 files changed, 286 insertions(+), 23 deletions(-)

-- 
2.24.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v4 0/5] Introduce flags to virDomainGetHostname()

Posted by Erik Skultety 2 weeks ago
On Thu, Jan 09, 2020 at 01:45:55PM +0100, Michal Privoznik wrote:
> v4 of:
>
> https://www.redhat.com/archives/libvir-list/2019-December/msg01453.html
>
> diff to v3:
> - I've split Julio's one patch into 4 smaller ones,
> - I've fixed issues I've raised in v3, like new error code (patch 1/5 is
>   completely new that's why I'm authoring it), fixed the completer and
>   some memleaks.

I'm tempted to say Safe for freeze for patches 2-5, but since you're adding an
enhancement, I'm afraid this will have to wait until 6.1.0 even though it's a
straightforward change, sorry for a late review :(.

Erik

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v4 0/5] Introduce flags to virDomainGetHostname()

Posted by Michal Privoznik 1 week ago
On 1/9/20 1:45 PM, Michal Privoznik wrote:
> 

Pushed now.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list