qemu: backup: Fixes and improvements

[libvirt] [PATCH 08/11] schemas: backup: Remove pointless <choice> for 'name' of backup disk

Posted by Peter Krempa 6 years, 1 month ago

One of the first versions thought of using disk path as the second
option but this was dropped as being a legacy interface. Remove the
leftover pointless <choice> wrapper for the disk name as there's just
one option now.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 docs/schemas/domainbackup.rng | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/docs/schemas/domainbackup.rng b/docs/schemas/domainbackup.rng
index 7286acb18c..c1e4d80302 100644
--- a/docs/schemas/domainbackup.rng
+++ b/docs/schemas/domainbackup.rng
@@ -104,9 +104,7 @@
         <oneOrMore>
           <element name='disk'>
             <attribute name='name'>
-              <choice>
-                <ref name='diskTarget'/>
-              </choice>
+              <ref name='diskTarget'/>
             </attribute>
             <choice>
               <group>
@@ -165,9 +163,7 @@
         <oneOrMore>
           <element name='disk'>
             <attribute name='name'>
-              <choice>
-                <ref name='diskTarget'/>
-              </choice>
+              <ref name='diskTarget'/>
             </attribute>
             <choice>
               <group>
-- 
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 08/11] schemas: backup: Remove pointless <choice> for 'name' of backup disk

Posted by Daniel P. Berrangé 6 years, 1 month ago

On Fri, Dec 20, 2019 at 02:25:26PM +0100, Peter Krempa wrote:
> One of the first versions thought of using disk path as the second
> option but this was dropped as being a legacy interface. Remove the
> leftover pointless <choice> wrapper for the disk name as there's just
> one option now.
> 
> Signed-off-by: Peter Krempa <pkrempa@redhat.com>
> ---
>  docs/schemas/domainbackup.rng | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list