qemu: backup: Fixes and improvements

[libvirt] [PATCH 01/11] qemu: block: Use proper asyncJob when waiting for completion of blockdev-create

Posted by Peter Krempa 6 years, 1 month ago

The waiting loop used QEMU_ASYNC_JOB_NONE rather than 'asyncJob' passed
from the caller.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/qemu/qemu_block.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c
index 95a2702f9d..eab21bc107 100644
--- a/src/qemu/qemu_block.c
+++ b/src/qemu/qemu_block.c
@@ -2406,11 +2406,11 @@ qemuBlockStorageSourceCreateGeneric(virDomainObjPtr vm,

     qemuBlockJobStarted(job, vm);

-    qemuBlockJobUpdate(vm, job, QEMU_ASYNC_JOB_NONE);
+    qemuBlockJobUpdate(vm, job, asyncJob);
     while (qemuBlockJobIsRunning(job))  {
         if (virDomainObjWait(vm) < 0)
             goto cleanup;
-        qemuBlockJobUpdate(vm, job, QEMU_ASYNC_JOB_NONE);
+        qemuBlockJobUpdate(vm, job, asyncJob);
     }

     if (job->state == QEMU_BLOCKJOB_STATE_FAILED ||
-- 
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 01/11] qemu: block: Use proper asyncJob when waiting for completion of blockdev-create

Posted by Daniel P. Berrangé 6 years, 1 month ago

On Fri, Dec 20, 2019 at 02:25:19PM +0100, Peter Krempa wrote:
> The waiting loop used QEMU_ASYNC_JOB_NONE rather than 'asyncJob' passed
> from the caller.
> 
> Signed-off-by: Peter Krempa <pkrempa@redhat.com>
> ---
>  src/qemu/qemu_block.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list