[v2] Incremental backup support for qemu

[libvirt] [PATCH v2 06/25] API: Add domain job operation for backups

Posted by Peter Krempa 6 years, 2 months ago

Introduce VIR_DOMAIN_JOB_OPERATION_BACKUP into virDomainJobOperation.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 include/libvirt/libvirt-domain.h | 1 +
 tools/virsh-domain.c             | 4 +++-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h
index 84c5492a7b..6d1c7f1a3b 100644
--- a/include/libvirt/libvirt-domain.h
+++ b/include/libvirt/libvirt-domain.h
@@ -3269,6 +3269,7 @@ typedef enum {
     VIR_DOMAIN_JOB_OPERATION_SNAPSHOT = 6,
     VIR_DOMAIN_JOB_OPERATION_SNAPSHOT_REVERT = 7,
     VIR_DOMAIN_JOB_OPERATION_DUMP = 8,
+    VIR_DOMAIN_JOB_OPERATION_BACKUP = 9,

 # ifdef VIR_ENUM_SENTINELS
     VIR_DOMAIN_JOB_OPERATION_LAST
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index bb942267f0..5c313279d7 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -6068,7 +6068,9 @@ VIR_ENUM_IMPL(virshDomainJobOperation,
               N_("Outgoing migration"),
               N_("Snapshot"),
               N_("Snapshot revert"),
-              N_("Dump"));
+              N_("Dump"),
+              N_("Backup"),
+);

 static const char *
 virshDomainJobOperationToString(int op)
-- 
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 06/25] API: Add domain job operation for backups

Posted by Daniel P. Berrangé 6 years, 2 months ago

On Tue, Dec 03, 2019 at 06:17:28PM +0100, Peter Krempa wrote:
> Introduce VIR_DOMAIN_JOB_OPERATION_BACKUP into virDomainJobOperation.
> 
> Signed-off-by: Peter Krempa <pkrempa@redhat.com>
> ---
>  include/libvirt/libvirt-domain.h | 1 +
>  tools/virsh-domain.c             | 4 +++-
>  2 files changed, 4 insertions(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 06/25] API: Add domain job operation for backups

Posted by Ján Tomko 6 years, 2 months ago

On Tue, Dec 03, 2019 at 06:17:28PM +0100, Peter Krempa wrote:
>Introduce VIR_DOMAIN_JOB_OPERATION_BACKUP into virDomainJobOperation.
>
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> include/libvirt/libvirt-domain.h | 1 +
> tools/virsh-domain.c             | 4 +++-
> 2 files changed, 4 insertions(+), 1 deletion(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 06/25] API: Add domain job operation for backups

Posted by Eric Blake 6 years, 2 months ago

On 12/3/19 11:17 AM, Peter Krempa wrote:
> Introduce VIR_DOMAIN_JOB_OPERATION_BACKUP into virDomainJobOperation.
> 
> Signed-off-by: Peter Krempa <pkrempa@redhat.com>
> ---
>   include/libvirt/libvirt-domain.h | 1 +
>   tools/virsh-domain.c             | 4 +++-
>   2 files changed, 4 insertions(+), 1 deletion(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h
> index 84c5492a7b..6d1c7f1a3b 100644
> --- a/include/libvirt/libvirt-domain.h
> +++ b/include/libvirt/libvirt-domain.h
> @@ -3269,6 +3269,7 @@ typedef enum {
>       VIR_DOMAIN_JOB_OPERATION_SNAPSHOT = 6,
>       VIR_DOMAIN_JOB_OPERATION_SNAPSHOT_REVERT = 7,
>       VIR_DOMAIN_JOB_OPERATION_DUMP = 8,
> +    VIR_DOMAIN_JOB_OPERATION_BACKUP = 9,
> 
>   # ifdef VIR_ENUM_SENTINELS
>       VIR_DOMAIN_JOB_OPERATION_LAST
> diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
> index bb942267f0..5c313279d7 100644
> --- a/tools/virsh-domain.c
> +++ b/tools/virsh-domain.c
> @@ -6068,7 +6068,9 @@ VIR_ENUM_IMPL(virshDomainJobOperation,
>                 N_("Outgoing migration"),
>                 N_("Snapshot"),
>                 N_("Snapshot revert"),
> -              N_("Dump"));
> +              N_("Dump"),
> +              N_("Backup"),
> +);
> 
>   static const char *
>   virshDomainJobOperationToString(int op)
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list