This shaves off 4 % of syntax-check runtime on my 8-core system,
     which is enough of a reason for me.
Surely it saves more on our overloaded CI workers.

Ján Tomko (3):
  scripts: speedup prohibit-duplicate-header
  scripts: check-aclrules: use in instead of find
  scripts: check-aclrules: use regular expressions less often

 scripts/check-aclrules.py            | 38 ++++++++++++++++++----------
 scripts/prohibit-duplicate-header.py |  4 +++
 2 files changed, 29 insertions(+), 13 deletions(-)

-- 
2.19.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On 11/20/19 3:32 PM, Ján Tomko wrote:
> This shaves off 4 % of syntax-check runtime on my 8-core system,
>       which is enough of a reason for me.


Around 10% increase on my system running 'make -j syntax-check'.



All patches:


Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On 11/20/19 4:34 PM, Daniel Henrique Barboza wrote:
> 
> 
> On 11/20/19 3:32 PM, Ján Tomko wrote:
>> This shaves off 4 % of syntax-check runtime on my 8-core system,
>>       which is enough of a reason for me.
> 
> 
> Around 10% increase on my system running 'make -j syntax-check'.

In time: *performance* increase. Did a few runs, on average these patches
made syntax-check 10% faster for me (~11 seconds without, ~10 seconds with
them).



Thanks,


DHB


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list