[libvirt] [PATCH v2 00/14] drop usage of c-type gnulib module

Pavel Hrdina posted 14 patches 4 years, 5 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1574261216.git.phrdina@redhat.com
bootstrap.conf                         |  1 -
build-aux/syntax-check.mk              | 11 ++---------
src/bhyve/bhyve_parse_command.c        |  3 +--
src/conf/network_conf.c                |  3 +--
src/conf/nwfilter_conf.c               |  3 +--
src/interface/interface_backend_udev.c |  5 ++---
src/libxl/libxl_conf.c                 |  3 +--
src/node_device/node_device_udev.c     |  3 +--
src/qemu/qemu_agent.c                  |  3 +--
src/qemu/qemu_domain.c                 |  3 +--
src/qemu/qemu_monitor.c                |  3 +--
src/qemu/qemu_qapi.c                   |  4 +---
src/remote/remote_driver.c             |  3 +--
src/rpc/virnetsocket.c                 |  3 +--
src/storage/parthelper.c               |  5 ++---
src/util/virbitmap.c                   |  5 ++---
src/util/virconf.c                     | 18 +++++++++---------
src/util/virfile.c                     |  8 +++-----
src/util/virhostcpu.c                  |  7 +++----
src/util/virkeyfile.c                  | 13 +++++++------
src/util/virmacaddr.c                  | 11 +++++------
src/util/virnetdevvportprofile.c       |  3 +--
src/util/virpidfile.c                  |  3 +--
src/util/virstoragefile.c              |  3 +--
src/util/virstring.c                   | 13 ++++++-------
src/util/virutil.c                     | 11 +++++------
src/util/viruuid.c                     |  9 ++++-----
src/vmx/vmx.c                          |  8 +++-----
tools/virsh-console.c                  |  3 +--
tools/virsh-domain.c                   |  3 +--
tools/vsh-table.c                      |  5 ++---
tools/vsh.c                            |  5 ++---
32 files changed, 73 insertions(+), 111 deletions(-)
[libvirt] [PATCH v2 00/14] drop usage of c-type gnulib module
Posted by Pavel Hrdina 4 years, 5 months ago
Changes in v2:
    - fixed missing parentheses in patch 01
    - added patch 02 to cover c_isascii

Pavel Hrdina (14):
  util: define IS_BLANK instead of using c_isblank from gnulib
  virkeyfile: define IS_ASCII instead c_isascii from gnulib
  use g_ascii_isalnum instead of c_isalnum from gnulib
  use g_ascii_isalpha instead of c_isalpha from gnulib
  use g_ascii_iscntrl instead of c_iscntrl from gnulib
  use g_ascii_isdigit instead of c_isdigit frum gnulib
  use g_ascii_islower instead of c_islower from gnulib
  use g_ascii_isprint instead of c_isprint from gnulib
  use g_ascii_isspace instead of c_isspace from gnulib
  use g_ascii_isxdigit instead of c_isxdigit from gnulib
  use g_ascii_tolower instead of c_tolower from gnulib
  use g_ascii_toupper instead of c_toupper from gnulib
  syntax-check: update c-type checks to refer to Glib
  bootstrap.conf: drop usage of c-type gnulib module

 bootstrap.conf                         |  1 -
 build-aux/syntax-check.mk              | 11 ++---------
 src/bhyve/bhyve_parse_command.c        |  3 +--
 src/conf/network_conf.c                |  3 +--
 src/conf/nwfilter_conf.c               |  3 +--
 src/interface/interface_backend_udev.c |  5 ++---
 src/libxl/libxl_conf.c                 |  3 +--
 src/node_device/node_device_udev.c     |  3 +--
 src/qemu/qemu_agent.c                  |  3 +--
 src/qemu/qemu_domain.c                 |  3 +--
 src/qemu/qemu_monitor.c                |  3 +--
 src/qemu/qemu_qapi.c                   |  4 +---
 src/remote/remote_driver.c             |  3 +--
 src/rpc/virnetsocket.c                 |  3 +--
 src/storage/parthelper.c               |  5 ++---
 src/util/virbitmap.c                   |  5 ++---
 src/util/virconf.c                     | 18 +++++++++---------
 src/util/virfile.c                     |  8 +++-----
 src/util/virhostcpu.c                  |  7 +++----
 src/util/virkeyfile.c                  | 13 +++++++------
 src/util/virmacaddr.c                  | 11 +++++------
 src/util/virnetdevvportprofile.c       |  3 +--
 src/util/virpidfile.c                  |  3 +--
 src/util/virstoragefile.c              |  3 +--
 src/util/virstring.c                   | 13 ++++++-------
 src/util/virutil.c                     | 11 +++++------
 src/util/viruuid.c                     |  9 ++++-----
 src/vmx/vmx.c                          |  8 +++-----
 tools/virsh-console.c                  |  3 +--
 tools/virsh-domain.c                   |  3 +--
 tools/vsh-table.c                      |  5 ++---
 tools/vsh.c                            |  5 ++---
 32 files changed, 73 insertions(+), 111 deletions(-)

-- 
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 00/14] drop usage of c-type gnulib module
Posted by Cole Robinson 4 years, 4 months ago
On 11/20/19 9:48 AM, Pavel Hrdina wrote:
> Changes in v2:
>     - fixed missing parentheses in patch 01
>     - added patch 02 to cover c_isascii
> 

With the two issues I pointed out fixed:

Reviewed-by: Cole Robinson <crobinso@redhat.com>

- Cole

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 00/14] drop usage of c-type gnulib module
Posted by Pavel Hrdina 4 years, 4 months ago
On Sun, Dec 08, 2019 at 06:36:22PM -0500, Cole Robinson wrote:
> On 11/20/19 9:48 AM, Pavel Hrdina wrote:
> > Changes in v2:
> >     - fixed missing parentheses in patch 01
> >     - added patch 02 to cover c_isascii
> > 
> 
> With the two issues I pointed out fixed:
> 
> Reviewed-by: Cole Robinson <crobinso@redhat.com>

Thanks, fixed and pushed.

Pavel
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list