domaincaps: Simplify adding of new domain capability features

[libvirt] [PATCH 4/8] conf: domaincaps: Add 'iothreads' to the features section

Posted by Peter Krempa 6 years, 2 months ago

Historically iothreads were the first feature and thus didn't have it's
own section. Add them to <features> for consistency with other features.

Unfortunately we must keep the original one in place.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 docs/schemas/domaincaps.rng                       | 3 +++
 src/conf/domain_capabilities.c                    | 1 +
 tests/domaincapsdata/libxl-xenfv.xml              | 1 +
 tests/domaincapsdata/libxl-xenpv.xml              | 1 +
 tests/domaincapsdata/qemu_1.5.3-q35.x86_64.xml    | 1 +
 tests/domaincapsdata/qemu_1.5.3-tcg.x86_64.xml    | 1 +
 tests/domaincapsdata/qemu_1.5.3.x86_64.xml        | 1 +
 tests/domaincapsdata/qemu_1.6.0-q35.x86_64.xml    | 1 +
 tests/domaincapsdata/qemu_1.6.0-tcg.x86_64.xml    | 1 +
 tests/domaincapsdata/qemu_1.6.0.x86_64.xml        | 1 +
 tests/domaincapsdata/qemu_1.7.0-q35.x86_64.xml    | 1 +
 tests/domaincapsdata/qemu_1.7.0-tcg.x86_64.xml    | 1 +
 tests/domaincapsdata/qemu_1.7.0.x86_64.xml        | 1 +
 tests/domaincapsdata/qemu_2.1.1-q35.x86_64.xml    | 1 +
 tests/domaincapsdata/qemu_2.1.1-tcg.x86_64.xml    | 1 +
 tests/domaincapsdata/qemu_2.1.1.x86_64.xml        | 1 +
 tests/domaincapsdata/qemu_2.10.0-q35.x86_64.xml   | 1 +
 tests/domaincapsdata/qemu_2.10.0-tcg.x86_64.xml   | 1 +
 tests/domaincapsdata/qemu_2.10.0-virt.aarch64.xml | 1 +
 tests/domaincapsdata/qemu_2.10.0.aarch64.xml      | 1 +
 tests/domaincapsdata/qemu_2.10.0.ppc64.xml        | 1 +
 tests/domaincapsdata/qemu_2.10.0.s390x.xml        | 1 +
 tests/domaincapsdata/qemu_2.10.0.x86_64.xml       | 1 +
 tests/domaincapsdata/qemu_2.11.0-q35.x86_64.xml   | 1 +
 tests/domaincapsdata/qemu_2.11.0-tcg.x86_64.xml   | 1 +
 tests/domaincapsdata/qemu_2.11.0.s390x.xml        | 1 +
 tests/domaincapsdata/qemu_2.11.0.x86_64.xml       | 1 +
 tests/domaincapsdata/qemu_2.12.0-q35.x86_64.xml   | 1 +
 tests/domaincapsdata/qemu_2.12.0-tcg.x86_64.xml   | 1 +
 tests/domaincapsdata/qemu_2.12.0-virt.aarch64.xml | 1 +
 tests/domaincapsdata/qemu_2.12.0.aarch64.xml      | 1 +
 tests/domaincapsdata/qemu_2.12.0.ppc64.xml        | 1 +
 tests/domaincapsdata/qemu_2.12.0.s390x.xml        | 1 +
 tests/domaincapsdata/qemu_2.12.0.x86_64.xml       | 1 +
 tests/domaincapsdata/qemu_2.4.0-q35.x86_64.xml    | 1 +
 tests/domaincapsdata/qemu_2.4.0-tcg.x86_64.xml    | 1 +
 tests/domaincapsdata/qemu_2.4.0.x86_64.xml        | 1 +
 tests/domaincapsdata/qemu_2.5.0-q35.x86_64.xml    | 1 +
 tests/domaincapsdata/qemu_2.5.0-tcg.x86_64.xml    | 1 +
 tests/domaincapsdata/qemu_2.5.0.x86_64.xml        | 1 +
 tests/domaincapsdata/qemu_2.6.0-q35.x86_64.xml    | 1 +
 tests/domaincapsdata/qemu_2.6.0-tcg.x86_64.xml    | 1 +
 tests/domaincapsdata/qemu_2.6.0-virt.aarch64.xml  | 1 +
 tests/domaincapsdata/qemu_2.6.0.aarch64.xml       | 1 +
 tests/domaincapsdata/qemu_2.6.0.ppc64.xml         | 1 +
 tests/domaincapsdata/qemu_2.6.0.x86_64.xml        | 1 +
 tests/domaincapsdata/qemu_2.7.0-q35.x86_64.xml    | 1 +
 tests/domaincapsdata/qemu_2.7.0-tcg.x86_64.xml    | 1 +
 tests/domaincapsdata/qemu_2.7.0.s390x.xml         | 1 +
 tests/domaincapsdata/qemu_2.7.0.x86_64.xml        | 1 +
 tests/domaincapsdata/qemu_2.8.0-q35.x86_64.xml    | 1 +
 tests/domaincapsdata/qemu_2.8.0-tcg.x86_64.xml    | 1 +
 tests/domaincapsdata/qemu_2.8.0.s390x.xml         | 1 +
 tests/domaincapsdata/qemu_2.8.0.x86_64.xml        | 1 +
 tests/domaincapsdata/qemu_2.9.0-q35.x86_64.xml    | 1 +
 tests/domaincapsdata/qemu_2.9.0-tcg.x86_64.xml    | 1 +
 tests/domaincapsdata/qemu_2.9.0.ppc64.xml         | 1 +
 tests/domaincapsdata/qemu_2.9.0.s390x.xml         | 1 +
 tests/domaincapsdata/qemu_2.9.0.x86_64.xml        | 1 +
 tests/domaincapsdata/qemu_3.0.0-q35.x86_64.xml    | 1 +
 tests/domaincapsdata/qemu_3.0.0-tcg.x86_64.xml    | 1 +
 tests/domaincapsdata/qemu_3.0.0.ppc64.xml         | 1 +
 tests/domaincapsdata/qemu_3.0.0.s390x.xml         | 1 +
 tests/domaincapsdata/qemu_3.0.0.x86_64.xml        | 1 +
 tests/domaincapsdata/qemu_3.1.0-q35.x86_64.xml    | 1 +
 tests/domaincapsdata/qemu_3.1.0-tcg.x86_64.xml    | 1 +
 tests/domaincapsdata/qemu_3.1.0.ppc64.xml         | 1 +
 tests/domaincapsdata/qemu_3.1.0.x86_64.xml        | 1 +
 tests/domaincapsdata/qemu_4.0.0-q35.x86_64.xml    | 1 +
 tests/domaincapsdata/qemu_4.0.0-tcg.x86_64.xml    | 1 +
 tests/domaincapsdata/qemu_4.0.0-virt.aarch64.xml  | 1 +
 tests/domaincapsdata/qemu_4.0.0.aarch64.xml       | 1 +
 tests/domaincapsdata/qemu_4.0.0.ppc64.xml         | 1 +
 tests/domaincapsdata/qemu_4.0.0.s390x.xml         | 1 +
 tests/domaincapsdata/qemu_4.0.0.x86_64.xml        | 1 +
 tests/domaincapsdata/qemu_4.1.0-q35.x86_64.xml    | 1 +
 tests/domaincapsdata/qemu_4.1.0-tcg.x86_64.xml    | 1 +
 tests/domaincapsdata/qemu_4.1.0.x86_64.xml        | 1 +
 tests/domaincapsdata/qemu_4.2.0-q35.x86_64.xml    | 1 +
 tests/domaincapsdata/qemu_4.2.0-tcg.x86_64.xml    | 1 +
 tests/domaincapsdata/qemu_4.2.0-virt.aarch64.xml  | 1 +
 tests/domaincapsdata/qemu_4.2.0.aarch64.xml       | 1 +
 tests/domaincapsdata/qemu_4.2.0.ppc64.xml         | 1 +
 tests/domaincapsdata/qemu_4.2.0.x86_64.xml        | 1 +
 84 files changed, 86 insertions(+)

diff --git a/docs/schemas/domaincaps.rng b/docs/schemas/domaincaps.rng
index 3525c0eeef..1072483092 100644
--- a/docs/schemas/domaincaps.rng
+++ b/docs/schemas/domaincaps.rng
@@ -201,6 +201,9 @@
       <optional>
         <ref name='gic'/>
       </optional>
+      <optional>
+        <ref name='iothreads'/>
+      </optional>
       <optional>
         <ref name='vmcoreinfo'/>
       </optional>
diff --git a/src/conf/domain_capabilities.c b/src/conf/domain_capabilities.c
index d9a9093f89..8d0a0c121c 100644
--- a/src/conf/domain_capabilities.c
+++ b/src/conf/domain_capabilities.c
@@ -607,6 +607,7 @@ virDomainCapsFormatFeatures(const virDomainCaps *caps,
     g_auto(virBuffer) childBuf = VIR_BUFFER_INIT_CHILD(buf);

     virDomainCapsFeatureGICFormat(&childBuf, &caps->gic);
+    qemuDomainCapsFeatureFormatSimple(&childBuf, "iothreads", caps->iothreads);
     qemuDomainCapsFeatureFormatSimple(&childBuf, "vmcoreinfo", caps->vmcoreinfo);
     qemuDomainCapsFeatureFormatSimple(&childBuf, "genid", caps->genid);
     virDomainCapsFeatureSEVFormat(&childBuf, caps->sev);
diff --git a/tests/domaincapsdata/libxl-xenfv.xml b/tests/domaincapsdata/libxl-xenfv.xml
index 4efc137c97..867817538c 100644
--- a/tests/domaincapsdata/libxl-xenfv.xml
+++ b/tests/domaincapsdata/libxl-xenfv.xml
@@ -72,6 +72,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='no'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/libxl-xenpv.xml b/tests/domaincapsdata/libxl-xenpv.xml
index 70e598fe9e..699a78e097 100644
--- a/tests/domaincapsdata/libxl-xenpv.xml
+++ b/tests/domaincapsdata/libxl-xenpv.xml
@@ -62,6 +62,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='no'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_1.5.3-q35.x86_64.xml b/tests/domaincapsdata/qemu_1.5.3-q35.x86_64.xml
index c6b090ed06..3fb8babfce 100644
--- a/tests/domaincapsdata/qemu_1.5.3-q35.x86_64.xml
+++ b/tests/domaincapsdata/qemu_1.5.3-q35.x86_64.xml
@@ -127,6 +127,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='no'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_1.5.3-tcg.x86_64.xml b/tests/domaincapsdata/qemu_1.5.3-tcg.x86_64.xml
index a1112c8011..2365b70725 100644
--- a/tests/domaincapsdata/qemu_1.5.3-tcg.x86_64.xml
+++ b/tests/domaincapsdata/qemu_1.5.3-tcg.x86_64.xml
@@ -127,6 +127,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='no'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_1.5.3.x86_64.xml b/tests/domaincapsdata/qemu_1.5.3.x86_64.xml
index 905593616a..a9575e76ae 100644
--- a/tests/domaincapsdata/qemu_1.5.3.x86_64.xml
+++ b/tests/domaincapsdata/qemu_1.5.3.x86_64.xml
@@ -127,6 +127,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='no'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_1.6.0-q35.x86_64.xml b/tests/domaincapsdata/qemu_1.6.0-q35.x86_64.xml
index 866e627287..e4b3bc76b6 100644
--- a/tests/domaincapsdata/qemu_1.6.0-q35.x86_64.xml
+++ b/tests/domaincapsdata/qemu_1.6.0-q35.x86_64.xml
@@ -127,6 +127,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='no'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_1.6.0-tcg.x86_64.xml b/tests/domaincapsdata/qemu_1.6.0-tcg.x86_64.xml
index 5b06cb8895..14562e587f 100644
--- a/tests/domaincapsdata/qemu_1.6.0-tcg.x86_64.xml
+++ b/tests/domaincapsdata/qemu_1.6.0-tcg.x86_64.xml
@@ -127,6 +127,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='no'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_1.6.0.x86_64.xml b/tests/domaincapsdata/qemu_1.6.0.x86_64.xml
index 788f8ac36b..f1921fc427 100644
--- a/tests/domaincapsdata/qemu_1.6.0.x86_64.xml
+++ b/tests/domaincapsdata/qemu_1.6.0.x86_64.xml
@@ -127,6 +127,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='no'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_1.7.0-q35.x86_64.xml b/tests/domaincapsdata/qemu_1.7.0-q35.x86_64.xml
index 79b753fa09..7fc2e8c792 100644
--- a/tests/domaincapsdata/qemu_1.7.0-q35.x86_64.xml
+++ b/tests/domaincapsdata/qemu_1.7.0-q35.x86_64.xml
@@ -127,6 +127,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='no'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_1.7.0-tcg.x86_64.xml b/tests/domaincapsdata/qemu_1.7.0-tcg.x86_64.xml
index 5b61c5ba4f..d1ba43f3df 100644
--- a/tests/domaincapsdata/qemu_1.7.0-tcg.x86_64.xml
+++ b/tests/domaincapsdata/qemu_1.7.0-tcg.x86_64.xml
@@ -127,6 +127,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='no'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_1.7.0.x86_64.xml b/tests/domaincapsdata/qemu_1.7.0.x86_64.xml
index a2df336833..c622a3dbe2 100644
--- a/tests/domaincapsdata/qemu_1.7.0.x86_64.xml
+++ b/tests/domaincapsdata/qemu_1.7.0.x86_64.xml
@@ -127,6 +127,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='no'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_2.1.1-q35.x86_64.xml b/tests/domaincapsdata/qemu_2.1.1-q35.x86_64.xml
index 901eb71442..b60e0be208 100644
--- a/tests/domaincapsdata/qemu_2.1.1-q35.x86_64.xml
+++ b/tests/domaincapsdata/qemu_2.1.1-q35.x86_64.xml
@@ -128,6 +128,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_2.1.1-tcg.x86_64.xml b/tests/domaincapsdata/qemu_2.1.1-tcg.x86_64.xml
index 2524e2fb4d..a28a53ce15 100644
--- a/tests/domaincapsdata/qemu_2.1.1-tcg.x86_64.xml
+++ b/tests/domaincapsdata/qemu_2.1.1-tcg.x86_64.xml
@@ -128,6 +128,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_2.1.1.x86_64.xml b/tests/domaincapsdata/qemu_2.1.1.x86_64.xml
index 6ad05cb6df..506142c37e 100644
--- a/tests/domaincapsdata/qemu_2.1.1.x86_64.xml
+++ b/tests/domaincapsdata/qemu_2.1.1.x86_64.xml
@@ -128,6 +128,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_2.10.0-q35.x86_64.xml b/tests/domaincapsdata/qemu_2.10.0-q35.x86_64.xml
index 60d565bcb5..c8c4996575 100644
--- a/tests/domaincapsdata/qemu_2.10.0-q35.x86_64.xml
+++ b/tests/domaincapsdata/qemu_2.10.0-q35.x86_64.xml
@@ -151,6 +151,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='no'/>
     <genid supported='yes'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_2.10.0-tcg.x86_64.xml b/tests/domaincapsdata/qemu_2.10.0-tcg.x86_64.xml
index c6c7ee3adb..c52e76e0f2 100644
--- a/tests/domaincapsdata/qemu_2.10.0-tcg.x86_64.xml
+++ b/tests/domaincapsdata/qemu_2.10.0-tcg.x86_64.xml
@@ -170,6 +170,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='no'/>
     <genid supported='yes'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_2.10.0-virt.aarch64.xml b/tests/domaincapsdata/qemu_2.10.0-virt.aarch64.xml
index a73d3ed413..425667c427 100644
--- a/tests/domaincapsdata/qemu_2.10.0-virt.aarch64.xml
+++ b/tests/domaincapsdata/qemu_2.10.0-virt.aarch64.xml
@@ -135,6 +135,7 @@
         <value>2</value>
       </enum>
     </gic>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_2.10.0.aarch64.xml b/tests/domaincapsdata/qemu_2.10.0.aarch64.xml
index 9523ff0088..3d5ab3046f 100644
--- a/tests/domaincapsdata/qemu_2.10.0.aarch64.xml
+++ b/tests/domaincapsdata/qemu_2.10.0.aarch64.xml
@@ -129,6 +129,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_2.10.0.ppc64.xml b/tests/domaincapsdata/qemu_2.10.0.ppc64.xml
index 4341b7506e..71aeda7745 100644
--- a/tests/domaincapsdata/qemu_2.10.0.ppc64.xml
+++ b/tests/domaincapsdata/qemu_2.10.0.ppc64.xml
@@ -101,6 +101,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_2.10.0.s390x.xml b/tests/domaincapsdata/qemu_2.10.0.s390x.xml
index a3c934fb94..82fa12b249 100644
--- a/tests/domaincapsdata/qemu_2.10.0.s390x.xml
+++ b/tests/domaincapsdata/qemu_2.10.0.s390x.xml
@@ -191,6 +191,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_2.10.0.x86_64.xml b/tests/domaincapsdata/qemu_2.10.0.x86_64.xml
index 6bc4f5b15a..e771bfec9d 100644
--- a/tests/domaincapsdata/qemu_2.10.0.x86_64.xml
+++ b/tests/domaincapsdata/qemu_2.10.0.x86_64.xml
@@ -151,6 +151,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='no'/>
     <genid supported='yes'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_2.11.0-q35.x86_64.xml b/tests/domaincapsdata/qemu_2.11.0-q35.x86_64.xml
index 008471bf7f..bb1ae91d18 100644
--- a/tests/domaincapsdata/qemu_2.11.0-q35.x86_64.xml
+++ b/tests/domaincapsdata/qemu_2.11.0-q35.x86_64.xml
@@ -149,6 +149,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='yes'/>
     <genid supported='yes'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_2.11.0-tcg.x86_64.xml b/tests/domaincapsdata/qemu_2.11.0-tcg.x86_64.xml
index 7030638338..83fa35ec5b 100644
--- a/tests/domaincapsdata/qemu_2.11.0-tcg.x86_64.xml
+++ b/tests/domaincapsdata/qemu_2.11.0-tcg.x86_64.xml
@@ -165,6 +165,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='yes'/>
     <genid supported='yes'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_2.11.0.s390x.xml b/tests/domaincapsdata/qemu_2.11.0.s390x.xml
index df410ffc48..5d8a23d919 100644
--- a/tests/domaincapsdata/qemu_2.11.0.s390x.xml
+++ b/tests/domaincapsdata/qemu_2.11.0.s390x.xml
@@ -190,6 +190,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_2.11.0.x86_64.xml b/tests/domaincapsdata/qemu_2.11.0.x86_64.xml
index 590825fa77..995a32b80c 100644
--- a/tests/domaincapsdata/qemu_2.11.0.x86_64.xml
+++ b/tests/domaincapsdata/qemu_2.11.0.x86_64.xml
@@ -149,6 +149,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='yes'/>
     <genid supported='yes'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_2.12.0-q35.x86_64.xml b/tests/domaincapsdata/qemu_2.12.0-q35.x86_64.xml
index 584eaa0983..500ae42858 100644
--- a/tests/domaincapsdata/qemu_2.12.0-q35.x86_64.xml
+++ b/tests/domaincapsdata/qemu_2.12.0-q35.x86_64.xml
@@ -162,6 +162,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='yes'/>
     <genid supported='yes'/>
     <sev supported='yes'>
diff --git a/tests/domaincapsdata/qemu_2.12.0-tcg.x86_64.xml b/tests/domaincapsdata/qemu_2.12.0-tcg.x86_64.xml
index 2fbd83d04d..b9d86deed7 100644
--- a/tests/domaincapsdata/qemu_2.12.0-tcg.x86_64.xml
+++ b/tests/domaincapsdata/qemu_2.12.0-tcg.x86_64.xml
@@ -176,6 +176,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='yes'/>
     <genid supported='yes'/>
     <sev supported='yes'>
diff --git a/tests/domaincapsdata/qemu_2.12.0-virt.aarch64.xml b/tests/domaincapsdata/qemu_2.12.0-virt.aarch64.xml
index ed1af3224b..3e6a51db21 100644
--- a/tests/domaincapsdata/qemu_2.12.0-virt.aarch64.xml
+++ b/tests/domaincapsdata/qemu_2.12.0-virt.aarch64.xml
@@ -137,6 +137,7 @@
         <value>3</value>
       </enum>
     </gic>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='yes'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_2.12.0.aarch64.xml b/tests/domaincapsdata/qemu_2.12.0.aarch64.xml
index ebf499d4fa..22d4df2de4 100644
--- a/tests/domaincapsdata/qemu_2.12.0.aarch64.xml
+++ b/tests/domaincapsdata/qemu_2.12.0.aarch64.xml
@@ -131,6 +131,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='yes'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_2.12.0.ppc64.xml b/tests/domaincapsdata/qemu_2.12.0.ppc64.xml
index e8d3c22337..1e87db5ca7 100644
--- a/tests/domaincapsdata/qemu_2.12.0.ppc64.xml
+++ b/tests/domaincapsdata/qemu_2.12.0.ppc64.xml
@@ -101,6 +101,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_2.12.0.s390x.xml b/tests/domaincapsdata/qemu_2.12.0.s390x.xml
index 8d039f3514..70f486318f 100644
--- a/tests/domaincapsdata/qemu_2.12.0.s390x.xml
+++ b/tests/domaincapsdata/qemu_2.12.0.s390x.xml
@@ -189,6 +189,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_2.12.0.x86_64.xml b/tests/domaincapsdata/qemu_2.12.0.x86_64.xml
index 109162ffd8..829a6aa5b9 100644
--- a/tests/domaincapsdata/qemu_2.12.0.x86_64.xml
+++ b/tests/domaincapsdata/qemu_2.12.0.x86_64.xml
@@ -162,6 +162,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='yes'/>
     <genid supported='yes'/>
     <sev supported='yes'>
diff --git a/tests/domaincapsdata/qemu_2.4.0-q35.x86_64.xml b/tests/domaincapsdata/qemu_2.4.0-q35.x86_64.xml
index b27c701794..333a2309e3 100644
--- a/tests/domaincapsdata/qemu_2.4.0-q35.x86_64.xml
+++ b/tests/domaincapsdata/qemu_2.4.0-q35.x86_64.xml
@@ -136,6 +136,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_2.4.0-tcg.x86_64.xml b/tests/domaincapsdata/qemu_2.4.0-tcg.x86_64.xml
index aca986f1da..cbd3555b56 100644
--- a/tests/domaincapsdata/qemu_2.4.0-tcg.x86_64.xml
+++ b/tests/domaincapsdata/qemu_2.4.0-tcg.x86_64.xml
@@ -136,6 +136,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_2.4.0.x86_64.xml b/tests/domaincapsdata/qemu_2.4.0.x86_64.xml
index 3257b723d9..4cec54bae5 100644
--- a/tests/domaincapsdata/qemu_2.4.0.x86_64.xml
+++ b/tests/domaincapsdata/qemu_2.4.0.x86_64.xml
@@ -136,6 +136,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_2.5.0-q35.x86_64.xml b/tests/domaincapsdata/qemu_2.5.0-q35.x86_64.xml
index 89b5a7e5a5..3910fdda6a 100644
--- a/tests/domaincapsdata/qemu_2.5.0-q35.x86_64.xml
+++ b/tests/domaincapsdata/qemu_2.5.0-q35.x86_64.xml
@@ -136,6 +136,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_2.5.0-tcg.x86_64.xml b/tests/domaincapsdata/qemu_2.5.0-tcg.x86_64.xml
index 390cfc07e2..986055b5d7 100644
--- a/tests/domaincapsdata/qemu_2.5.0-tcg.x86_64.xml
+++ b/tests/domaincapsdata/qemu_2.5.0-tcg.x86_64.xml
@@ -136,6 +136,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_2.5.0.x86_64.xml b/tests/domaincapsdata/qemu_2.5.0.x86_64.xml
index a519cd8c03..de58a35456 100644
--- a/tests/domaincapsdata/qemu_2.5.0.x86_64.xml
+++ b/tests/domaincapsdata/qemu_2.5.0.x86_64.xml
@@ -136,6 +136,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_2.6.0-q35.x86_64.xml b/tests/domaincapsdata/qemu_2.6.0-q35.x86_64.xml
index e2d734fd03..6351b32983 100644
--- a/tests/domaincapsdata/qemu_2.6.0-q35.x86_64.xml
+++ b/tests/domaincapsdata/qemu_2.6.0-q35.x86_64.xml
@@ -136,6 +136,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_2.6.0-tcg.x86_64.xml b/tests/domaincapsdata/qemu_2.6.0-tcg.x86_64.xml
index d054bb0491..9b170ef53e 100644
--- a/tests/domaincapsdata/qemu_2.6.0-tcg.x86_64.xml
+++ b/tests/domaincapsdata/qemu_2.6.0-tcg.x86_64.xml
@@ -136,6 +136,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_2.6.0-virt.aarch64.xml b/tests/domaincapsdata/qemu_2.6.0-virt.aarch64.xml
index 13441b9923..537d17d153 100644
--- a/tests/domaincapsdata/qemu_2.6.0-virt.aarch64.xml
+++ b/tests/domaincapsdata/qemu_2.6.0-virt.aarch64.xml
@@ -134,6 +134,7 @@
         <value>2</value>
       </enum>
     </gic>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_2.6.0.aarch64.xml b/tests/domaincapsdata/qemu_2.6.0.aarch64.xml
index 974739c38e..ce57457769 100644
--- a/tests/domaincapsdata/qemu_2.6.0.aarch64.xml
+++ b/tests/domaincapsdata/qemu_2.6.0.aarch64.xml
@@ -128,6 +128,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_2.6.0.ppc64.xml b/tests/domaincapsdata/qemu_2.6.0.ppc64.xml
index 9f628a3652..f37d9cf4d0 100644
--- a/tests/domaincapsdata/qemu_2.6.0.ppc64.xml
+++ b/tests/domaincapsdata/qemu_2.6.0.ppc64.xml
@@ -101,6 +101,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_2.6.0.x86_64.xml b/tests/domaincapsdata/qemu_2.6.0.x86_64.xml
index bb1f784328..6c8442d7c4 100644
--- a/tests/domaincapsdata/qemu_2.6.0.x86_64.xml
+++ b/tests/domaincapsdata/qemu_2.6.0.x86_64.xml
@@ -136,6 +136,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_2.7.0-q35.x86_64.xml b/tests/domaincapsdata/qemu_2.7.0-q35.x86_64.xml
index a04e7e23db..b1aad6357c 100644
--- a/tests/domaincapsdata/qemu_2.7.0-q35.x86_64.xml
+++ b/tests/domaincapsdata/qemu_2.7.0-q35.x86_64.xml
@@ -137,6 +137,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_2.7.0-tcg.x86_64.xml b/tests/domaincapsdata/qemu_2.7.0-tcg.x86_64.xml
index e5bd79bff0..5e8ae81294 100644
--- a/tests/domaincapsdata/qemu_2.7.0-tcg.x86_64.xml
+++ b/tests/domaincapsdata/qemu_2.7.0-tcg.x86_64.xml
@@ -137,6 +137,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_2.7.0.s390x.xml b/tests/domaincapsdata/qemu_2.7.0.s390x.xml
index 322d12c719..87736d5a68 100644
--- a/tests/domaincapsdata/qemu_2.7.0.s390x.xml
+++ b/tests/domaincapsdata/qemu_2.7.0.s390x.xml
@@ -94,6 +94,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_2.7.0.x86_64.xml b/tests/domaincapsdata/qemu_2.7.0.x86_64.xml
index 697bac48ac..2b7f7c5536 100644
--- a/tests/domaincapsdata/qemu_2.7.0.x86_64.xml
+++ b/tests/domaincapsdata/qemu_2.7.0.x86_64.xml
@@ -137,6 +137,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_2.8.0-q35.x86_64.xml b/tests/domaincapsdata/qemu_2.8.0-q35.x86_64.xml
index e1f014d4a8..75b9612ef1 100644
--- a/tests/domaincapsdata/qemu_2.8.0-q35.x86_64.xml
+++ b/tests/domaincapsdata/qemu_2.8.0-q35.x86_64.xml
@@ -137,6 +137,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_2.8.0-tcg.x86_64.xml b/tests/domaincapsdata/qemu_2.8.0-tcg.x86_64.xml
index b6679a6e64..8a27376cf5 100644
--- a/tests/domaincapsdata/qemu_2.8.0-tcg.x86_64.xml
+++ b/tests/domaincapsdata/qemu_2.8.0-tcg.x86_64.xml
@@ -137,6 +137,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_2.8.0.s390x.xml b/tests/domaincapsdata/qemu_2.8.0.s390x.xml
index c7a4578f61..bfaff118cd 100644
--- a/tests/domaincapsdata/qemu_2.8.0.s390x.xml
+++ b/tests/domaincapsdata/qemu_2.8.0.s390x.xml
@@ -175,6 +175,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_2.8.0.x86_64.xml b/tests/domaincapsdata/qemu_2.8.0.x86_64.xml
index 3af3fcc4a9..3bb3f14527 100644
--- a/tests/domaincapsdata/qemu_2.8.0.x86_64.xml
+++ b/tests/domaincapsdata/qemu_2.8.0.x86_64.xml
@@ -137,6 +137,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_2.9.0-q35.x86_64.xml b/tests/domaincapsdata/qemu_2.9.0-q35.x86_64.xml
index aac295a20d..b2b4cb0008 100644
--- a/tests/domaincapsdata/qemu_2.9.0-q35.x86_64.xml
+++ b/tests/domaincapsdata/qemu_2.9.0-q35.x86_64.xml
@@ -146,6 +146,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='no'/>
     <genid supported='yes'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_2.9.0-tcg.x86_64.xml b/tests/domaincapsdata/qemu_2.9.0-tcg.x86_64.xml
index 12537c039b..3bb3ee334a 100644
--- a/tests/domaincapsdata/qemu_2.9.0-tcg.x86_64.xml
+++ b/tests/domaincapsdata/qemu_2.9.0-tcg.x86_64.xml
@@ -169,6 +169,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='no'/>
     <genid supported='yes'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_2.9.0.ppc64.xml b/tests/domaincapsdata/qemu_2.9.0.ppc64.xml
index 73ed4f4897..be83fe45ef 100644
--- a/tests/domaincapsdata/qemu_2.9.0.ppc64.xml
+++ b/tests/domaincapsdata/qemu_2.9.0.ppc64.xml
@@ -101,6 +101,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_2.9.0.s390x.xml b/tests/domaincapsdata/qemu_2.9.0.s390x.xml
index eb7dfe6b67..9f30a4f711 100644
--- a/tests/domaincapsdata/qemu_2.9.0.s390x.xml
+++ b/tests/domaincapsdata/qemu_2.9.0.s390x.xml
@@ -176,6 +176,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_2.9.0.x86_64.xml b/tests/domaincapsdata/qemu_2.9.0.x86_64.xml
index 80fc7e1657..ba01257a8d 100644
--- a/tests/domaincapsdata/qemu_2.9.0.x86_64.xml
+++ b/tests/domaincapsdata/qemu_2.9.0.x86_64.xml
@@ -146,6 +146,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='no'/>
     <genid supported='yes'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_3.0.0-q35.x86_64.xml b/tests/domaincapsdata/qemu_3.0.0-q35.x86_64.xml
index 44dc5d44d2..e4d859f07b 100644
--- a/tests/domaincapsdata/qemu_3.0.0-q35.x86_64.xml
+++ b/tests/domaincapsdata/qemu_3.0.0-q35.x86_64.xml
@@ -162,6 +162,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='yes'/>
     <genid supported='yes'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_3.0.0-tcg.x86_64.xml b/tests/domaincapsdata/qemu_3.0.0-tcg.x86_64.xml
index 489e4ae1f7..c957c3da4f 100644
--- a/tests/domaincapsdata/qemu_3.0.0-tcg.x86_64.xml
+++ b/tests/domaincapsdata/qemu_3.0.0-tcg.x86_64.xml
@@ -177,6 +177,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='yes'/>
     <genid supported='yes'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_3.0.0.ppc64.xml b/tests/domaincapsdata/qemu_3.0.0.ppc64.xml
index 1a7f12c615..c0e963160c 100644
--- a/tests/domaincapsdata/qemu_3.0.0.ppc64.xml
+++ b/tests/domaincapsdata/qemu_3.0.0.ppc64.xml
@@ -102,6 +102,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_3.0.0.s390x.xml b/tests/domaincapsdata/qemu_3.0.0.s390x.xml
index 0e81e2ea33..993be87460 100644
--- a/tests/domaincapsdata/qemu_3.0.0.s390x.xml
+++ b/tests/domaincapsdata/qemu_3.0.0.s390x.xml
@@ -195,6 +195,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_3.0.0.x86_64.xml b/tests/domaincapsdata/qemu_3.0.0.x86_64.xml
index 8e10a3eb0e..0eaf59c71b 100644
--- a/tests/domaincapsdata/qemu_3.0.0.x86_64.xml
+++ b/tests/domaincapsdata/qemu_3.0.0.x86_64.xml
@@ -162,6 +162,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='yes'/>
     <genid supported='yes'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_3.1.0-q35.x86_64.xml b/tests/domaincapsdata/qemu_3.1.0-q35.x86_64.xml
index 595476b87b..f136c168d7 100644
--- a/tests/domaincapsdata/qemu_3.1.0-q35.x86_64.xml
+++ b/tests/domaincapsdata/qemu_3.1.0-q35.x86_64.xml
@@ -165,6 +165,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='yes'/>
     <genid supported='yes'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_3.1.0-tcg.x86_64.xml b/tests/domaincapsdata/qemu_3.1.0-tcg.x86_64.xml
index 82d31b3ff6..f75b660b39 100644
--- a/tests/domaincapsdata/qemu_3.1.0-tcg.x86_64.xml
+++ b/tests/domaincapsdata/qemu_3.1.0-tcg.x86_64.xml
@@ -180,6 +180,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='yes'/>
     <genid supported='yes'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_3.1.0.ppc64.xml b/tests/domaincapsdata/qemu_3.1.0.ppc64.xml
index d6952076e9..9d81f324f1 100644
--- a/tests/domaincapsdata/qemu_3.1.0.ppc64.xml
+++ b/tests/domaincapsdata/qemu_3.1.0.ppc64.xml
@@ -103,6 +103,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_3.1.0.x86_64.xml b/tests/domaincapsdata/qemu_3.1.0.x86_64.xml
index 059403cebc..6dfb88a7be 100644
--- a/tests/domaincapsdata/qemu_3.1.0.x86_64.xml
+++ b/tests/domaincapsdata/qemu_3.1.0.x86_64.xml
@@ -165,6 +165,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='yes'/>
     <genid supported='yes'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_4.0.0-q35.x86_64.xml b/tests/domaincapsdata/qemu_4.0.0-q35.x86_64.xml
index aba5bdf871..cd1ac0e42d 100644
--- a/tests/domaincapsdata/qemu_4.0.0-q35.x86_64.xml
+++ b/tests/domaincapsdata/qemu_4.0.0-q35.x86_64.xml
@@ -165,6 +165,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='yes'/>
     <genid supported='yes'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_4.0.0-tcg.x86_64.xml b/tests/domaincapsdata/qemu_4.0.0-tcg.x86_64.xml
index 3630653ac9..0402007ddc 100644
--- a/tests/domaincapsdata/qemu_4.0.0-tcg.x86_64.xml
+++ b/tests/domaincapsdata/qemu_4.0.0-tcg.x86_64.xml
@@ -180,6 +180,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='yes'/>
     <genid supported='yes'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_4.0.0-virt.aarch64.xml b/tests/domaincapsdata/qemu_4.0.0-virt.aarch64.xml
index 9f9cc376a3..c495662ca0 100644
--- a/tests/domaincapsdata/qemu_4.0.0-virt.aarch64.xml
+++ b/tests/domaincapsdata/qemu_4.0.0-virt.aarch64.xml
@@ -143,6 +143,7 @@
         <value>3</value>
       </enum>
     </gic>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='yes'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_4.0.0.aarch64.xml b/tests/domaincapsdata/qemu_4.0.0.aarch64.xml
index 577edf81d7..5c05f75b83 100644
--- a/tests/domaincapsdata/qemu_4.0.0.aarch64.xml
+++ b/tests/domaincapsdata/qemu_4.0.0.aarch64.xml
@@ -137,6 +137,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='yes'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_4.0.0.ppc64.xml b/tests/domaincapsdata/qemu_4.0.0.ppc64.xml
index 5422b3ddd8..00f107a06e 100644
--- a/tests/domaincapsdata/qemu_4.0.0.ppc64.xml
+++ b/tests/domaincapsdata/qemu_4.0.0.ppc64.xml
@@ -104,6 +104,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_4.0.0.s390x.xml b/tests/domaincapsdata/qemu_4.0.0.s390x.xml
index e68f8e8d9a..a682b83203 100644
--- a/tests/domaincapsdata/qemu_4.0.0.s390x.xml
+++ b/tests/domaincapsdata/qemu_4.0.0.s390x.xml
@@ -201,6 +201,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_4.0.0.x86_64.xml b/tests/domaincapsdata/qemu_4.0.0.x86_64.xml
index eb24b9a604..516761b259 100644
--- a/tests/domaincapsdata/qemu_4.0.0.x86_64.xml
+++ b/tests/domaincapsdata/qemu_4.0.0.x86_64.xml
@@ -165,6 +165,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='yes'/>
     <genid supported='yes'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_4.1.0-q35.x86_64.xml b/tests/domaincapsdata/qemu_4.1.0-q35.x86_64.xml
index 481aba2c41..8c5eb8e0e5 100644
--- a/tests/domaincapsdata/qemu_4.1.0-q35.x86_64.xml
+++ b/tests/domaincapsdata/qemu_4.1.0-q35.x86_64.xml
@@ -169,6 +169,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='yes'/>
     <genid supported='yes'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_4.1.0-tcg.x86_64.xml b/tests/domaincapsdata/qemu_4.1.0-tcg.x86_64.xml
index a7409505cb..e78a463f2c 100644
--- a/tests/domaincapsdata/qemu_4.1.0-tcg.x86_64.xml
+++ b/tests/domaincapsdata/qemu_4.1.0-tcg.x86_64.xml
@@ -180,6 +180,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='yes'/>
     <genid supported='yes'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_4.1.0.x86_64.xml b/tests/domaincapsdata/qemu_4.1.0.x86_64.xml
index f5685d2068..6e0dd633c8 100644
--- a/tests/domaincapsdata/qemu_4.1.0.x86_64.xml
+++ b/tests/domaincapsdata/qemu_4.1.0.x86_64.xml
@@ -169,6 +169,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='yes'/>
     <genid supported='yes'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_4.2.0-q35.x86_64.xml b/tests/domaincapsdata/qemu_4.2.0-q35.x86_64.xml
index 8f6c6d3da6..d6d25a909c 100644
--- a/tests/domaincapsdata/qemu_4.2.0-q35.x86_64.xml
+++ b/tests/domaincapsdata/qemu_4.2.0-q35.x86_64.xml
@@ -169,6 +169,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='yes'/>
     <genid supported='yes'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_4.2.0-tcg.x86_64.xml b/tests/domaincapsdata/qemu_4.2.0-tcg.x86_64.xml
index 520d4ff7f2..5b5b236761 100644
--- a/tests/domaincapsdata/qemu_4.2.0-tcg.x86_64.xml
+++ b/tests/domaincapsdata/qemu_4.2.0-tcg.x86_64.xml
@@ -180,6 +180,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='yes'/>
     <genid supported='yes'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_4.2.0-virt.aarch64.xml b/tests/domaincapsdata/qemu_4.2.0-virt.aarch64.xml
index 85d9433f52..8ee9bfcd7f 100644
--- a/tests/domaincapsdata/qemu_4.2.0-virt.aarch64.xml
+++ b/tests/domaincapsdata/qemu_4.2.0-virt.aarch64.xml
@@ -143,6 +143,7 @@
         <value>3</value>
       </enum>
     </gic>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='yes'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_4.2.0.aarch64.xml b/tests/domaincapsdata/qemu_4.2.0.aarch64.xml
index 577edf81d7..5c05f75b83 100644
--- a/tests/domaincapsdata/qemu_4.2.0.aarch64.xml
+++ b/tests/domaincapsdata/qemu_4.2.0.aarch64.xml
@@ -137,6 +137,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='yes'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_4.2.0.ppc64.xml b/tests/domaincapsdata/qemu_4.2.0.ppc64.xml
index 78e141dfb2..a82e4f5997 100644
--- a/tests/domaincapsdata/qemu_4.2.0.ppc64.xml
+++ b/tests/domaincapsdata/qemu_4.2.0.ppc64.xml
@@ -104,6 +104,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='no'/>
     <genid supported='no'/>
     <sev supported='no'/>
diff --git a/tests/domaincapsdata/qemu_4.2.0.x86_64.xml b/tests/domaincapsdata/qemu_4.2.0.x86_64.xml
index 5bd376bb2e..1dbf7a91a1 100644
--- a/tests/domaincapsdata/qemu_4.2.0.x86_64.xml
+++ b/tests/domaincapsdata/qemu_4.2.0.x86_64.xml
@@ -169,6 +169,7 @@
   </devices>
   <features>
     <gic supported='no'/>
+    <iothreads supported='yes'/>
     <vmcoreinfo supported='yes'/>
     <genid supported='yes'/>
     <sev supported='no'/>
-- 
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 4/8] conf: domaincaps: Add 'iothreads' to the features section

Posted by Ján Tomko 6 years, 2 months ago

On Wed, Nov 13, 2019 at 05:05:22PM +0100, Peter Krempa wrote:
>Historically iothreads were the first feature and thus didn't have it's
>own section. Add them to <features> for consistency with other features.
>

I'm not convinced duplicating this is a good idea - apps looking into
the <features> element for iothread support would only find it with
libvirt new enough to have it there and miss out on iothread support
with older libvirt.

Jano

>Unfortunately we must keep the original one in place.
>
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> docs/schemas/domaincaps.rng                       | 3 +++
> src/conf/domain_capabilities.c                    | 1 +
> tests/domaincapsdata/libxl-xenfv.xml              | 1 +
> tests/domaincapsdata/libxl-xenpv.xml              | 1 +
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 4/8] conf: domaincaps: Add 'iothreads' to the features section

Posted by Peter Krempa 6 years, 2 months ago

On Thu, Nov 14, 2019 at 12:55:40 +0100, Ján Tomko wrote:
> On Wed, Nov 13, 2019 at 05:05:22PM +0100, Peter Krempa wrote:
> > Historically iothreads were the first feature and thus didn't have it's
> > own section. Add them to <features> for consistency with other features.
> > 
> 
> I'm not convinced duplicating this is a good idea - apps looking into
> the <features> element for iothread support would only find it with
> libvirt new enough to have it there and miss out on iothread support
> with older libvirt.

I certainly can keep 'iothreads' separate. I'm definitely not going to
add an special case into the formatter to avoid formatting it there.

Also to be fair I'm not sure whether it's worth caring about the
outlined scenario. If an APP looks for iothreads in <features> it should
not be used with older libvirt than the one where it was added.

At any rate, I can drop this patch and keep the iothreads stuff
separate.

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 4/8] conf: domaincaps: Add 'iothreads' to the features section

Posted by Peter Krempa 6 years, 2 months ago

On Thu, Nov 14, 2019 at 12:59:00 +0100, Peter Krempa wrote:
> On Thu, Nov 14, 2019 at 12:55:40 +0100, Ján Tomko wrote:
> > On Wed, Nov 13, 2019 at 05:05:22PM +0100, Peter Krempa wrote:
> > > Historically iothreads were the first feature and thus didn't have it's
> > > own section. Add them to <features> for consistency with other features.
> > > 
> > 
> > I'm not convinced duplicating this is a good idea - apps looking into
> > the <features> element for iothread support would only find it with
> > libvirt new enough to have it there and miss out on iothread support
> > with older libvirt.
> 
> I certainly can keep 'iothreads' separate. I'm definitely not going to
> add an special case into the formatter to avoid formatting it there.
> 
> Also to be fair I'm not sure whether it's worth caring about the
> outlined scenario. If an APP looks for iothreads in <features> it should
> not be used with older libvirt than the one where it was added.
> 
> At any rate, I can drop this patch and keep the iothreads stuff
> separate.

Also any new app will have to write two lookup XPaths to get all the
data as it's now rather than having everything in one place.

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list