Remove use of 'areadlink' gnulib module (kill-a-gnulib-module-a-day initiative)

[libvirt] [PATCH 0/8] Remove use of 'areadlink' gnulib module (kill-a-gnulib-module-a-day initiative)

Posted by Peter Krempa 4 years, 5 months ago

This removes use of 'areadlink' by using 'g_file_read_link' and fixes a
few insane uses.

Note that I'll post the actual module deletion from bootstrap.conf
separately as touching that file results in lengthy rebuilds.

Peter Krempa (8):
  qemu: domain: Use g_file_read_link instead of virFileReadLink
  util: file: Remove virFileReadLink
  qemu: tpm: Use g_autofree in qemuTPMEmulatorGetPid
  qemu: tpm: Sanitize error values in qemuTPMEmulatorGetPid
  qemu: gpu: Sanitize error values in qemuVhostUserGPUGetPid
  util: pidfile: Sanitize return values of virPidFileReadIfAlive
  util: pidfile: Sanitize return values of virPidFileReadPathIfAlive
  util: pidfile: Replace 'areadlink' by 'g_file_read_link'

 src/libvirt_private.syms       |  1 -
 src/qemu/qemu_domain.c         | 18 +++++-----
 src/qemu/qemu_tpm.c            | 16 ++++-----
 src/qemu/qemu_vhost_user_gpu.c | 12 ++++---
 src/util/virfile.c             | 13 -------
 src/util/virfile.h             |  3 --
 src/util/virpidfile.c          | 64 +++++++++++++++++-----------------
 7 files changed, 56 insertions(+), 71 deletions(-)

-- 
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/8] Remove use of 'areadlink' gnulib module (kill-a-gnulib-module-a-day initiative)

Posted by Peter Krempa 4 years, 5 months ago

On Wed, Nov 13, 2019 at 14:07:01 +0100, Peter Krempa wrote:
> This removes use of 'areadlink' by using 'g_file_read_link' and fixes a
> few insane uses.
> 
> Note that I'll post the actual module deletion from bootstrap.conf
> separately as touching that file results in lengthy rebuilds.

The commits actually deleting the modules from bootstrap.conf will be
agreggated here:

https://gitlab.com/pipo.sk/libvirt/commits/gnulib

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/8] Remove use of 'areadlink' gnulib module (kill-a-gnulib-module-a-day initiative)

Posted by Ján Tomko 4 years, 5 months ago

On Wed, Nov 13, 2019 at 02:07:01PM +0100, Peter Krempa wrote:
>This removes use of 'areadlink' by using 'g_file_read_link' and fixes a
>few insane uses.
>
>Note that I'll post the actual module deletion from bootstrap.conf
>separately as touching that file results in lengthy rebuilds.
>
>Peter Krempa (8):
>  qemu: domain: Use g_file_read_link instead of virFileReadLink
>  util: file: Remove virFileReadLink
>  qemu: tpm: Use g_autofree in qemuTPMEmulatorGetPid
>  qemu: tpm: Sanitize error values in qemuTPMEmulatorGetPid
>  qemu: gpu: Sanitize error values in qemuVhostUserGPUGetPid
>  util: pidfile: Sanitize return values of virPidFileReadIfAlive
>  util: pidfile: Sanitize return values of virPidFileReadPathIfAlive
>  util: pidfile: Replace 'areadlink' by 'g_file_read_link'
>
> src/libvirt_private.syms       |  1 -
> src/qemu/qemu_domain.c         | 18 +++++-----
> src/qemu/qemu_tpm.c            | 16 ++++-----
> src/qemu/qemu_vhost_user_gpu.c | 12 ++++---
> src/util/virfile.c             | 13 -------
> src/util/virfile.h             |  3 --
> src/util/virpidfile.c          | 64 +++++++++++++++++-----------------
> 7 files changed, 56 insertions(+), 71 deletions(-)

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list