conf/caps: Modernize and clean up handling of domain caps

[libvirt] [PATCH 04/10] conf: storagecaps: Fix broken attempt at being const-correct

Posted by Peter Krempa 6 years, 2 months ago

The code formatting storage capabilities faithfully copied the wrong use
of 'const' from domain capabilities.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/conf/storage_capabilities.c | 4 ++--
 src/conf/storage_capabilities.h | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/conf/storage_capabilities.c b/src/conf/storage_capabilities.c
index cf3ee488ac..1a3417f90b 100644
--- a/src/conf/storage_capabilities.c
+++ b/src/conf/storage_capabilities.c
@@ -93,7 +93,7 @@ virStoragePoolCapsIsLoaded(virCapsPtr driverCaps,
 static int
 virStoragePoolCapsFormatPool(virBufferPtr buf,
                              int poolType,
-                             virStoragePoolCapsPtr const caps)
+                             const virStoragePoolCaps *caps)
 {
     bool isLoaded = virStoragePoolCapsIsLoaded(caps->driverCaps, poolType);

@@ -115,7 +115,7 @@ virStoragePoolCapsFormatPool(virBufferPtr buf,


 char *
-virStoragePoolCapsFormat(virStoragePoolCapsPtr const caps)
+virStoragePoolCapsFormat(const virStoragePoolCaps *caps)
 {
     virBuffer buf = VIR_BUFFER_INITIALIZER;
     size_t i;
diff --git a/src/conf/storage_capabilities.h b/src/conf/storage_capabilities.h
index 788ea227ea..377c313aa0 100644
--- a/src/conf/storage_capabilities.h
+++ b/src/conf/storage_capabilities.h
@@ -37,4 +37,4 @@ virStoragePoolCapsPtr
 virStoragePoolCapsNew(virCapsPtr driverCaps);

 char *
-virStoragePoolCapsFormat(virStoragePoolCapsPtr const caps);
+virStoragePoolCapsFormat(const virStoragePoolCaps *caps);
-- 
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 04/10] conf: storagecaps: Fix broken attempt at being const-correct

Posted by Daniel P. Berrangé 6 years, 2 months ago

On Tue, Nov 12, 2019 at 08:27:41AM +0100, Peter Krempa wrote:
> The code formatting storage capabilities faithfully copied the wrong use
> of 'const' from domain capabilities.
> 
> Signed-off-by: Peter Krempa <pkrempa@redhat.com>
> ---
>  src/conf/storage_capabilities.c | 4 ++--
>  src/conf/storage_capabilities.h | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list