Drop virAsprintf() in favor of g_strdup_printf()

[libvirt] [PATCH 37/75] access: Use g_strdup_printf() instead of virAsprintf()

Posted by Michal Privoznik 6 years, 3 months ago

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 src/access/viraccessdriverpolkit.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/access/viraccessdriverpolkit.c b/src/access/viraccessdriverpolkit.c
index 5d6c4204ff..1d6ff81391 100644
--- a/src/access/viraccessdriverpolkit.c
+++ b/src/access/viraccessdriverpolkit.c
@@ -59,8 +59,8 @@ virAccessDriverPolkitFormatAction(const char *typename,
     char *actionid = NULL;
     size_t i;
 
-    virAsprintf(&actionid, "%s.%s.%s", VIR_ACCESS_DRIVER_POLKIT_ACTION_PREFIX,
-                typename, permname);
+    actionid = g_strdup_printf("%s.%s.%s", VIR_ACCESS_DRIVER_POLKIT_ACTION_PREFIX,
+                               typename, permname);
 
     for (i = 0; actionid[i]; i++)
         if (actionid[i] == '_')
-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 37/75] access: Use g_strdup_printf() instead of virAsprintf()

Posted by Ján Tomko 6 years, 3 months ago

On Tue, Oct 22, 2019 at 03:57:41PM +0200, Michal Privoznik wrote:
>Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
>---
> src/access/viraccessdriverpolkit.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

If you absorb
[PATCH 03/75] access: Drop virAsprintf() and virAsprintfQuiet() retval
into this one:

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list