qemu: Add support for incremental backups

[libvirt] [PATCH RFC 06/40] qemu: domain: clarify sematics of qemuDomainPrepareDiskSourceData

Posted by Peter Krempa 6 years, 2 months ago

Note in the comment that this function prepares the storage source based
on the configuration of the disk.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/qemu/qemu_domain.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 29212eaa10..259cf51e2b 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -15088,8 +15088,8 @@ qemuDomainCheckCCWS390AddressSupport(const virDomainDef *def,
  * @src: source to start from
  *
  * Prepares various aspects of a storage source belonging to a disk backing
- * chain. This function should be also called for detected backing chain
- * members.
+ * chain based on the disk configuration. This function should be also called
+ * for detected backing chain members.
  */
 void
 qemuDomainPrepareDiskSourceData(virDomainDiskDefPtr disk,
-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH RFC 06/40] qemu: domain: clarify sematics of qemuDomainPrepareDiskSourceData

Posted by Daniel Henrique Barboza 6 years, 2 months ago


On 10/18/19 1:10 PM, Peter Krempa wrote:
> Note in the comment that this function prepares the storage source based
> on the configuration of the disk.
> 
> Signed-off-by: Peter Krempa <pkrempa@redhat.com>
> ---

Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>


>   src/qemu/qemu_domain.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
> index 29212eaa10..259cf51e2b 100644
> --- a/src/qemu/qemu_domain.c
> +++ b/src/qemu/qemu_domain.c
> @@ -15088,8 +15088,8 @@ qemuDomainCheckCCWS390AddressSupport(const virDomainDef *def,
>    * @src: source to start from
>    *
>    * Prepares various aspects of a storage source belonging to a disk backing
> - * chain. This function should be also called for detected backing chain
> - * members.
> + * chain based on the disk configuration. This function should be also called
> + * for detected backing chain members.
>    */
>   void
>   qemuDomainPrepareDiskSourceData(virDomainDiskDefPtr disk,
> 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list