conf: Fix up empty 'network' cdroms

[libvirt] [PATCH 0/2] conf: Fix up empty 'network' cdroms

Peter Krempa posted 2 patches 4 years, 6 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1571146430.git.pkrempa@redhat.com

Test syntax-check passed

src/conf/domain_conf.c                        |  4 +++
...m-empty-network-invalid.x86_64-latest.args | 34 +++++++++++++++++++
.../disk-cdrom-empty-network-invalid.xml      | 30 ++++++++++++++++
tests/qemuxml2argvtest.c                      |  1 +
...om-empty-network-invalid.x86_64-latest.xml | 34 +++++++++++++++++++
tests/qemuxml2xmloutdata/disk-source-pool.xml |  2 +-
tests/qemuxml2xmltest.c                       |  1 +
7 files changed, 105 insertions(+), 1 deletion(-)
create mode 100644 tests/qemuxml2argvdata/disk-cdrom-empty-network-invalid.x86_64-latest.args
create mode 100644 tests/qemuxml2argvdata/disk-cdrom-empty-network-invalid.xml
create mode 100644 tests/qemuxml2xmloutdata/disk-cdrom-empty-network-invalid.x86_64-latest.xml

Expand all Fold all

[libvirt] [PATCH 0/2] conf: Fix up empty 'network' cdroms

Posted by Peter Krempa 4 years, 6 months ago

Peter Krempa (2):
  conf: Reset disk type if <source> element is completely missing
  tests: Add test case for empty 'network' cdrom

 src/conf/domain_conf.c                        |  4 +++
 ...m-empty-network-invalid.x86_64-latest.args | 34 +++++++++++++++++++
 .../disk-cdrom-empty-network-invalid.xml      | 30 ++++++++++++++++
 tests/qemuxml2argvtest.c                      |  1 +
 ...om-empty-network-invalid.x86_64-latest.xml | 34 +++++++++++++++++++
 tests/qemuxml2xmloutdata/disk-source-pool.xml |  2 +-
 tests/qemuxml2xmltest.c                       |  1 +
 7 files changed, 105 insertions(+), 1 deletion(-)
 create mode 100644 tests/qemuxml2argvdata/disk-cdrom-empty-network-invalid.x86_64-latest.args
 create mode 100644 tests/qemuxml2argvdata/disk-cdrom-empty-network-invalid.xml
 create mode 100644 tests/qemuxml2xmloutdata/disk-cdrom-empty-network-invalid.x86_64-latest.xml

-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/2] conf: Fix up empty 'network' cdroms

Posted by Michal Privoznik 4 years, 6 months ago

On 10/15/19 3:35 PM, Peter Krempa wrote:
> Peter Krempa (2):
>    conf: Reset disk type if <source> element is completely missing
>    tests: Add test case for empty 'network' cdrom
> 
>   src/conf/domain_conf.c                        |  4 +++
>   ...m-empty-network-invalid.x86_64-latest.args | 34 +++++++++++++++++++
>   .../disk-cdrom-empty-network-invalid.xml      | 30 ++++++++++++++++
>   tests/qemuxml2argvtest.c                      |  1 +
>   ...om-empty-network-invalid.x86_64-latest.xml | 34 +++++++++++++++++++
>   tests/qemuxml2xmloutdata/disk-source-pool.xml |  2 +-
>   tests/qemuxml2xmltest.c                       |  1 +
>   7 files changed, 105 insertions(+), 1 deletion(-)
>   create mode 100644 tests/qemuxml2argvdata/disk-cdrom-empty-network-invalid.x86_64-latest.args
>   create mode 100644 tests/qemuxml2argvdata/disk-cdrom-empty-network-invalid.xml
>   create mode 100644 tests/qemuxml2xmloutdata/disk-cdrom-empty-network-invalid.x86_64-latest.xml
> 

I agree that this is not pretty, but I don't think there's a better way.

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list