storagefile, security: qcow2 data_file support

[libvirt] [PATCH 16/30] storagefile: Don't access backingStoreRaw directly in FromBackingRelative

Posted by Cole Robinson 6 years, 4 months ago

For the only usage, the rel == parent->backingStoreRaw, so drop
the direct access

Signed-off-by: Cole Robinson <crobinso@redhat.com>
---
 src/util/virstoragefile.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c
index 53fe4590b4..c47df6c200 100644
--- a/src/util/virstoragefile.c
+++ b/src/util/virstoragefile.c
@@ -2625,7 +2625,7 @@ virStorageSourceNewFromBackingRelative(virStorageSourcePtr parent,
         return NULL;
 
     /* store relative name */
-    if (VIR_STRDUP(def->relPath, parent->backingStoreRaw) < 0)
+    if (VIR_STRDUP(def->relPath, rel) < 0)
         return NULL;
 
     if (!(dirname = mdir_name(parent->path))) {
-- 
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 16/30] storagefile: Don't access backingStoreRaw directly in FromBackingRelative

Posted by Daniel Henrique Barboza 6 years, 4 months ago


On 10/7/19 6:49 PM, Cole Robinson wrote:
> For the only usage, the rel == parent->backingStoreRaw, so drop
> the direct access
>
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
> ---

Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>

>   src/util/virstoragefile.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c
> index 53fe4590b4..c47df6c200 100644
> --- a/src/util/virstoragefile.c
> +++ b/src/util/virstoragefile.c
> @@ -2625,7 +2625,7 @@ virStorageSourceNewFromBackingRelative(virStorageSourcePtr parent,
>           return NULL;
>   
>       /* store relative name */
> -    if (VIR_STRDUP(def->relPath, parent->backingStoreRaw) < 0)
> +    if (VIR_STRDUP(def->relPath, rel) < 0)
>           return NULL;
>   
>       if (!(dirname = mdir_name(parent->path))) {

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list