[libvirt] [PATCH 10/30] storagefile: Rename qcow2GetBackingStoreFormat

Cole Robinson posted 30 patches 6 years, 4 months ago
[libvirt] [PATCH 10/30] storagefile: Rename qcow2GetBackingStoreFormat
Posted by Cole Robinson 6 years, 4 months ago
...to qcow2GetExtensions. We will extend it for more extension
parsing in future patches

Signed-off-by: Cole Robinson <crobinso@redhat.com>
---
 src/util/virstoragefile.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c
index b8f7faf580..d6bd38777b 100644
--- a/src/util/virstoragefile.c
+++ b/src/util/virstoragefile.c
@@ -427,9 +427,9 @@ cowGetBackingStore(char **res,
 
 
 static int
-qcow2GetBackingStoreFormat(int *format,
-                           const char *buf,
-                           size_t buf_size)
+qcow2GetExtensions(int *format,
+                   const char *buf,
+                   size_t buf_size)
 {
     size_t offset;
     size_t extension_start;
@@ -561,7 +561,7 @@ qcowXGetBackingStore(char **res,
     memcpy(*res, buf + offset, size);
     (*res)[size] = '\0';
 
-    if (qcow2GetBackingStoreFormat(format, buf, buf_size) < 0)
+    if (qcow2GetExtensions(format, buf, buf_size) < 0)
         return BACKING_STORE_INVALID;
 
     return BACKING_STORE_OK;
-- 
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 10/30] storagefile: Rename qcow2GetBackingStoreFormat
Posted by Daniel Henrique Barboza 6 years, 4 months ago

On 10/7/19 6:49 PM, Cole Robinson wrote:
> ...to qcow2GetExtensions. We will extend it for more extension
> parsing in future patches
>
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
> ---

Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>

>   src/util/virstoragefile.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c
> index b8f7faf580..d6bd38777b 100644
> --- a/src/util/virstoragefile.c
> +++ b/src/util/virstoragefile.c
> @@ -427,9 +427,9 @@ cowGetBackingStore(char **res,
>   
>   
>   static int
> -qcow2GetBackingStoreFormat(int *format,
> -                           const char *buf,
> -                           size_t buf_size)
> +qcow2GetExtensions(int *format,
> +                   const char *buf,
> +                   size_t buf_size)
>   {
>       size_t offset;
>       size_t extension_start;
> @@ -561,7 +561,7 @@ qcowXGetBackingStore(char **res,
>       memcpy(*res, buf + offset, size);
>       (*res)[size] = '\0';
>   
> -    if (qcow2GetBackingStoreFormat(format, buf, buf_size) < 0)
> +    if (qcow2GetExtensions(format, buf, buf_size) < 0)
>           return BACKING_STORE_INVALID;
>   
>       return BACKING_STORE_OK;

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list