The checkpoint code is quite complex and was dispersed in many places.
Refactor it to be in one new separate file.

I also plan to do the same to the snapshot code once this is dealt with.

Additionally aggregating all the code in one place will allow
refactoring and reuse in the incremental backup implementation.

diff to v1:
- rebased on top of the patches to remove checking of AUTODESTROY
- kept only one instance of virCheckFlags per API (inside qemu_checkpoint.c)

Peter Krempa (7):
  qemu: Move, rename and export qemuDomObjFromDomain
  conf: Drop pointless 'domain' argument from
    virDomainCheckpointRedefinePrep
  conf: Drop pointless 'domain' argument from
    virDomainSnapshotRedefinePrep
  qemu: driver: Remove misplaced qemuDomainObjEndJob in
    qemuDomainCheckpointGetXMLDesc
  qemu: driver: Move checkpoint-related code to qemu_checkpoint.c
  qemu: domain: Move checkpoint related code to qemu_checkpoint.c
  qemu: driver: Don't pull in qemu_monitor_json.h directly

 src/conf/checkpoint_conf.c |   7 +-
 src/conf/checkpoint_conf.h |   3 +-
 src/conf/snapshot_conf.c   |   5 +-
 src/conf/snapshot_conf.h   |   3 +-
 src/qemu/Makefile.inc.am   |   2 +
 src/qemu/qemu_checkpoint.c | 646 ++++++++++++++++++++++++++++++++++
 src/qemu/qemu_checkpoint.h |  55 +++
 src/qemu/qemu_domain.c     | 193 ++---------
 src/qemu/qemu_domain.h     |  16 +-
 src/qemu/qemu_driver.c     | 689 ++++++++-----------------------------
 src/test/test_driver.c     |   4 +-
 11 files changed, 887 insertions(+), 736 deletions(-)
 create mode 100644 src/qemu/qemu_checkpoint.c
 create mode 100644 src/qemu/qemu_checkpoint.h

-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list