qemu: Clean up typed parameter handling in bulk stats

[libvirt] [PATCH 15/22] qemu: driver: Don't return anything from qemuDomainBlockStatsGatherTotals

Posted by Peter Krempa 6 years, 4 months ago

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/qemu/qemu_driver.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 2814d6825a..98ada96fe7 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -11411,7 +11411,7 @@ qemuDomainBlockResize(virDomainPtr dom,
 }


-static int
+static void
 qemuDomainBlockStatsGatherTotals(qemuBlockStatsPtr data,
                                  qemuBlockStatsPtr total)
 {
@@ -11423,7 +11423,6 @@ qemuDomainBlockStatsGatherTotals(qemuBlockStatsPtr data,
     total->wr_total_times += data->wr_total_times;
     total->rd_total_times += data->rd_total_times;
     total->flush_total_times += data->flush_total_times;
-    return 0;
 }


-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 15/22] qemu: driver: Don't return anything from qemuDomainBlockStatsGatherTotals

Posted by Ján Tomko 6 years, 4 months ago

On Thu, Sep 19, 2019 at 07:13:18PM +0200, Peter Krempa wrote:
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> src/qemu/qemu_driver.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list