[libvirt] [PATCH 05/22] docs: apibuild: Purge irrelevant typed parameter APIs from ignore

Peter Krempa posted 22 patches 6 years, 4 months ago
[libvirt] [PATCH 05/22] docs: apibuild: Purge irrelevant typed parameter APIs from ignore
Posted by Peter Krempa 6 years, 4 months ago
The internal helpers are not considered any more so we don't have to
ignore them either.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 docs/apibuild.py | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/docs/apibuild.py b/docs/apibuild.py
index 92886e1276..b59050f5ce 100755
--- a/docs/apibuild.py
+++ b/docs/apibuild.py
@@ -95,13 +95,8 @@ ignored_functions = {
   "virDomainMigrateConfirm3": "private function for migration",
   "virDomainMigratePrepareTunnel3": "private function for tunnelled migration",
   "DllMain": "specific function for Win32",
-  "virTypedParamsValidate": "internal function in virtypedparam.c",
   "virTypedParameterValidateSet": "internal function in virtypedparam.c",
-  "virTypedParameterAssign": "internal function in virtypedparam.c",
   "virTypedParameterAssignFromStr": "internal function in virtypedparam.c",
-  "virTypedParameterToString": "internal function in virtypedparam.c",
-  "virTypedParamsCheck": "internal function in virtypedparam.c",
-  "virTypedParamsCopy": "internal function in virtypedparam.c",
   "virDomainMigrateBegin3Params": "private function for migration",
   "virDomainMigrateFinish3Params": "private function for migration",
   "virDomainMigratePerform3Params": "private function for migration",
-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 05/22] docs: apibuild: Purge irrelevant typed parameter APIs from ignore
Posted by Ján Tomko 6 years, 4 months ago
On Thu, Sep 19, 2019 at 07:13:08PM +0200, Peter Krempa wrote:
>The internal helpers are not considered any more so we don't have to
>ignore them either.
>
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> docs/apibuild.py | 5 -----
> 1 file changed, 5 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

>diff --git a/docs/apibuild.py b/docs/apibuild.py
>index 92886e1276..b59050f5ce 100755
>--- a/docs/apibuild.py
>+++ b/docs/apibuild.py
>@@ -95,13 +95,8 @@ ignored_functions = {
>   "virDomainMigrateConfirm3": "private function for migration",
>   "virDomainMigratePrepareTunnel3": "private function for tunnelled migration",
>   "DllMain": "specific function for Win32",
>-  "virTypedParamsValidate": "internal function in virtypedparam.c",
>   "virTypedParameterValidateSet": "internal function in virtypedparam.c",

This one is in src/libvirt.c, can it be moved?

>-  "virTypedParameterAssign": "internal function in virtypedparam.c",
>   "virTypedParameterAssignFromStr": "internal function in virtypedparam.c",

You moved this one to virtypedparam-public.c a few commits above

>-  "virTypedParameterToString": "internal function in virtypedparam.c",
>-  "virTypedParamsCheck": "internal function in virtypedparam.c",
>-  "virTypedParamsCopy": "internal function in virtypedparam.c",
>   "virDomainMigrateBegin3Params": "private function for migration",
>   "virDomainMigrateFinish3Params": "private function for migration",
>   "virDomainMigratePerform3Params": "private function for migration",

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list