qemu: Clean up typed parameter handling in bulk stats

[libvirt] [PATCH 02/22] util: typedparam: Purge public bits from virTypedParamsGetStringList

Posted by Peter Krempa 6 years, 4 months ago

The function is not exported in the public API thus the error
dispatching is not required.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/util/virtypedparam.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/util/virtypedparam.c b/src/util/virtypedparam.c
index 7abf0257ce..acf8c39602 100644
--- a/src/util/virtypedparam.c
+++ b/src/util/virtypedparam.c
@@ -514,8 +514,6 @@ virTypedParamsGetStringList(virTypedParameterPtr params,
     int nfiltered;
     virTypedParameterPtr *filtered = NULL;

-    virResetLastError();
-
     virCheckNonNullArgGoto(values, error);
     *values = NULL;

@@ -540,7 +538,6 @@ virTypedParamsGetStringList(virTypedParameterPtr params,
     if (values)
         VIR_FREE(*values);
     VIR_FREE(filtered);
-    virDispatchError(NULL);
     return -1;
 }

-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 02/22] util: typedparam: Purge public bits from virTypedParamsGetStringList

Posted by Ján Tomko 6 years, 4 months ago

On Thu, Sep 19, 2019 at 07:13:05PM +0200, Peter Krempa wrote:
>The function is not exported in the public API thus the error
>dispatching is not required.
>
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> src/util/virtypedparam.c | 3 ---
> 1 file changed, 3 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list