qemu: monitor: Clean up some more HMP cruft

[libvirt] [PATCH 0/8] qemu: monitor: Clean up some more HMP cruft

Peter Krempa posted 8 patches 4 years, 7 months ago

Download series mbox

Test syntax-check passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1568909221.git.pkrempa@redhat.com

src/qemu/qemu_monitor.c      | 178 +----------------------------------
src/qemu/qemu_monitor.h      |  13 +--
src/qemu/qemu_monitor_json.c | 104 +++-----------------
src/qemu/qemu_monitor_json.h |  13 +--
src/qemu/qemu_monitor_text.c |  39 +++-----
tests/qemumonitortestutils.c |   6 +-
6 files changed, 32 insertions(+), 321 deletions(-)

Expand all Fold all

[libvirt] [PATCH 0/8] qemu: monitor: Clean up some more HMP cruft

Posted by Peter Krempa 4 years, 7 months ago

There was quite a bit of legacy HMP cruft. We can remove it as we use
HMP commands via QMP.

Peter Krempa (8):
  qemu: monitor: Remove legacy monitor commands for FD manipulation
  qemu: monitor: Remove qemuMonitorHMPCommand macro
  qemu: monitor: Remove support for HMP commands with fds
  qemu: monitor: Don't escape HMP commands just to unescape them right
    away
  qemu: monitor: Remove HMP command (un)escaping infrastructure
  qemu: monitor: Don't include text monitor in json monitor
  qemu: monitor: Don't handle HMP in qemuMonitorJSONArbitraryCommand
  qemu: monitor: Remove qemuMonitorHMPCommand in favor of
    qemuMonitorJSONHumanCommand

 src/qemu/qemu_monitor.c      | 178 +----------------------------------
 src/qemu/qemu_monitor.h      |  13 +--
 src/qemu/qemu_monitor_json.c | 104 +++-----------------
 src/qemu/qemu_monitor_json.h |  13 +--
 src/qemu/qemu_monitor_text.c |  39 +++-----
 tests/qemumonitortestutils.c |   6 +-
 6 files changed, 32 insertions(+), 321 deletions(-)

-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/8] qemu: monitor: Clean up some more HMP cruft

Posted by Jiri Denemark 4 years, 7 months ago

On Thu, Sep 19, 2019 at 18:10:15 +0200, Peter Krempa wrote:
> There was quite a bit of legacy HMP cruft. We can remove it as we use
> HMP commands via QMP.
> 
> Peter Krempa (8):
>   qemu: monitor: Remove legacy monitor commands for FD manipulation
>   qemu: monitor: Remove qemuMonitorHMPCommand macro
>   qemu: monitor: Remove support for HMP commands with fds
>   qemu: monitor: Don't escape HMP commands just to unescape them right
>     away
>   qemu: monitor: Remove HMP command (un)escaping infrastructure
>   qemu: monitor: Don't include text monitor in json monitor
>   qemu: monitor: Don't handle HMP in qemuMonitorJSONArbitraryCommand
>   qemu: monitor: Remove qemuMonitorHMPCommand in favor of
>     qemuMonitorJSONHumanCommand
> 
>  src/qemu/qemu_monitor.c      | 178 +----------------------------------
>  src/qemu/qemu_monitor.h      |  13 +--
>  src/qemu/qemu_monitor_json.c | 104 +++-----------------
>  src/qemu/qemu_monitor_json.h |  13 +--
>  src/qemu/qemu_monitor_text.c |  39 +++-----
>  tests/qemumonitortestutils.c |   6 +-
>  6 files changed, 32 insertions(+), 321 deletions(-)

Nice.

Reviewed-by: Jiri Denemark <jdenemar@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list