Don't colorize output senselessly

[libvirt] [PATCH 0/2] Don't colorize output senselessly

Peter Krempa posted 2 patches 4 years, 7 months ago

Download series mbox

Test syntax-check passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1568793426.git.pkrempa@redhat.com

m4/virt-colours.m4 | 62 ----------------------------------------------
m4/virt-result.m4  | 21 +++-------------
2 files changed, 3 insertions(+), 80 deletions(-)
delete mode 100644 m4/virt-colours.m4

Expand all Fold all

[libvirt] [PATCH 0/2] Don't colorize output senselessly

Posted by Peter Krempa 4 years, 7 months ago

Basing the colors on the message itself is in many cases wrong. Look
into the patches for examples.

Peter Krempa (2):
  Revert "virt-result.m4: Colourize summary printings"
  Revert "configure: Colorize output"

 m4/virt-colours.m4 | 62 ----------------------------------------------
 m4/virt-result.m4  | 21 +++-------------
 2 files changed, 3 insertions(+), 80 deletions(-)
 delete mode 100644 m4/virt-colours.m4

-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/2] Don't colorize output senselessly

Posted by Michal Prívozník 4 years, 7 months ago

On 9/18/19 9:58 AM, Peter Krempa wrote:
> Basing the colors on the message itself is in many cases wrong. Look
> into the patches for examples.
> 
> Peter Krempa (2):
>   Revert "virt-result.m4: Colourize summary printings"
>   Revert "configure: Colorize output"
> 
>  m4/virt-colours.m4 | 62 ----------------------------------------------
>  m4/virt-result.m4  | 21 +++-------------
>  2 files changed, 3 insertions(+), 80 deletions(-)
>  delete mode 100644 m4/virt-colours.m4
> 

Looks like this made people more angry than I anticipated. Feel free to
revert the patches.

ACK

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/2] Don't colorize output senselessly

Posted by Peter Krempa 4 years, 7 months ago

On Wed, Sep 18, 2019 at 16:18:23 +0200, Michal Privoznik wrote:
> On 9/18/19 9:58 AM, Peter Krempa wrote:
> > Basing the colors on the message itself is in many cases wrong. Look
> > into the patches for examples.
> > 
> > Peter Krempa (2):
> >   Revert "virt-result.m4: Colourize summary printings"
> >   Revert "configure: Colorize output"
> > 
> >  m4/virt-colours.m4 | 62 ----------------------------------------------
> >  m4/virt-result.m4  | 21 +++-------------
> >  2 files changed, 3 insertions(+), 80 deletions(-)
> >  delete mode 100644 m4/virt-colours.m4
> > 
> 
> Looks like this made people more angry than I anticipated. Feel free to
> revert the patches.

I want to emphasise that I don't have problem with using colored text to
simplify spotting problems. One example is the colored output of our
unit test suite where the usage of colors allows me to find a broken
test quickly.

> 
> ACK
> 
> Michal
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list