[libvirt] [PATCH v2 0/2] qemu: Enable slirp-helper iff dbus-vmstate present

Michal Privoznik posted 2 patches 1 week ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1568107000.git.mprivozn@redhat.com
src/qemu/qemu_capabilities.c                      | 5 -----
src/qemu/qemu_capabilities.h                      | 1 -
src/qemu/qemu_hotplug.c                           | 2 +-
src/qemu/qemu_process.c                           | 2 +-
tests/qemucapabilitiesdata/caps_4.0.0.aarch64.xml | 1 -
tests/qemucapabilitiesdata/caps_4.0.0.ppc64.xml   | 1 -
tests/qemucapabilitiesdata/caps_4.0.0.riscv32.xml | 1 -
tests/qemucapabilitiesdata/caps_4.0.0.riscv64.xml | 1 -
tests/qemucapabilitiesdata/caps_4.0.0.s390x.xml   | 1 -
tests/qemucapabilitiesdata/caps_4.0.0.x86_64.xml  | 1 -
tests/qemucapabilitiesdata/caps_4.1.0.x86_64.xml  | 1 -
tests/qemuxml2argvdata/net-user.x86_64-4.0.0.args | 2 +-
tests/qemuxml2argvtest.c                          | 2 +-
13 files changed, 4 insertions(+), 17 deletions(-)

[libvirt] [PATCH v2 0/2] qemu: Enable slirp-helper iff dbus-vmstate present

Posted by Michal Privoznik 1 week ago
This is technically a v2 of:

https://www.redhat.com/archives/libvir-list/2019-September/msg00281.html

It implements what Jano suggested - use dbus-vmstate capability to
decide if slirp-helper is used.

Michal Prívozník (2):
  qemu: Enable slirp-helper iff dbus-vmstate present
  Revert "qemu: add socket datagram capability"

 src/qemu/qemu_capabilities.c                      | 5 -----
 src/qemu/qemu_capabilities.h                      | 1 -
 src/qemu/qemu_hotplug.c                           | 2 +-
 src/qemu/qemu_process.c                           | 2 +-
 tests/qemucapabilitiesdata/caps_4.0.0.aarch64.xml | 1 -
 tests/qemucapabilitiesdata/caps_4.0.0.ppc64.xml   | 1 -
 tests/qemucapabilitiesdata/caps_4.0.0.riscv32.xml | 1 -
 tests/qemucapabilitiesdata/caps_4.0.0.riscv64.xml | 1 -
 tests/qemucapabilitiesdata/caps_4.0.0.s390x.xml   | 1 -
 tests/qemucapabilitiesdata/caps_4.0.0.x86_64.xml  | 1 -
 tests/qemucapabilitiesdata/caps_4.1.0.x86_64.xml  | 1 -
 tests/qemuxml2argvdata/net-user.x86_64-4.0.0.args | 2 +-
 tests/qemuxml2argvtest.c                          | 2 +-
 13 files changed, 4 insertions(+), 17 deletions(-)

-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 0/2] qemu: Enable slirp-helper iff dbus-vmstate present

Posted by Ján Tomko 4 days ago
On Tue, Sep 10, 2019 at 11:17:58AM +0200, Michal Privoznik wrote:
>This is technically a v2 of:
>
>https://www.redhat.com/archives/libvir-list/2019-September/msg00281.html
>
>It implements what Jano suggested - use dbus-vmstate capability to
>decide if slirp-helper is used.
>
>Michal Prívozník (2):
>  qemu: Enable slirp-helper iff dbus-vmstate present
>  Revert "qemu: add socket datagram capability"
>
> src/qemu/qemu_capabilities.c                      | 5 -----
> src/qemu/qemu_capabilities.h                      | 1 -
> src/qemu/qemu_hotplug.c                           | 2 +-
> src/qemu/qemu_process.c                           | 2 +-
> tests/qemucapabilitiesdata/caps_4.0.0.aarch64.xml | 1 -
> tests/qemucapabilitiesdata/caps_4.0.0.ppc64.xml   | 1 -
> tests/qemucapabilitiesdata/caps_4.0.0.riscv32.xml | 1 -
> tests/qemucapabilitiesdata/caps_4.0.0.riscv64.xml | 1 -
> tests/qemucapabilitiesdata/caps_4.0.0.s390x.xml   | 1 -
> tests/qemucapabilitiesdata/caps_4.0.0.x86_64.xml  | 1 -
> tests/qemucapabilitiesdata/caps_4.1.0.x86_64.xml  | 1 -
> tests/qemuxml2argvdata/net-user.x86_64-4.0.0.args | 2 +-

Note that this renders testing net-user for 4.0.0 bogus, but we can fix
that once we re-enable the feature.

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano

> tests/qemuxml2argvtest.c                          | 2 +-
> 13 files changed, 4 insertions(+), 17 deletions(-)
>
>-- 
>2.21.0
>
>--
>libvir-list mailing list
>libvir-list@redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list