conf: Avoid checking root element name in virDomainDefParseNode

[libvirt] [PATCH 0/2] conf: Avoid checking root element name in virDomainDefParseNode

Jiri Denemark posted 2 patches 4 years, 8 months ago

Download series mbox

Test syntax-check passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1568105090.git.jdenemar@redhat.com

src/conf/domain_conf.c | 29 ++++++++++++++++-------------
1 file changed, 16 insertions(+), 13 deletions(-)

Expand all Fold all

[libvirt] [PATCH 0/2] conf: Avoid checking root element name in virDomainDefParseNode

Posted by Jiri Denemark 4 years, 8 months ago

The only caller for which this check makes sense is virDomainDefParse.
Thus the check should be moved there.

Jiri Denemark (2):
  conf: Add cleanup label to virDomainDefParse
  conf: Avoid checking root element name in virDomainDefParseNode

 src/conf/domain_conf.c | 29 ++++++++++++++++-------------
 1 file changed, 16 insertions(+), 13 deletions(-)

-- 
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/2] conf: Avoid checking root element name in virDomainDefParseNode

Posted by Michal Privoznik 4 years, 8 months ago

On 9/10/19 10:45 AM, Jiri Denemark wrote:
> The only caller for which this check makes sense is virDomainDefParse.
> Thus the check should be moved there.
> 
> Jiri Denemark (2):
>    conf: Add cleanup label to virDomainDefParse
>    conf: Avoid checking root element name in virDomainDefParseNode
> 
>   src/conf/domain_conf.c | 29 ++++++++++++++++-------------
>   1 file changed, 16 insertions(+), 13 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list