[libvirt] [PATCH 0/4] Colourize configure output

Michal Privoznik posted 4 patches 24 weeks ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1568015323.git.mprivozn@redhat.com
configure.ac                 |  8 ++---
m4/virt-chrdev-lock-files.m4 |  2 +-
m4/virt-colours.m4           | 62 ++++++++++++++++++++++++++++++++++++
m4/virt-debug.m4             |  2 +-
m4/virt-default-editor.m4    |  2 +-
m4/virt-dtrace.m4            |  2 +-
m4/virt-host-validate.m4     |  2 +-
m4/virt-init-script.m4       |  2 +-
m4/virt-loader-nvram.m4      |  2 +-
m4/virt-login-shell.m4       |  2 +-
m4/virt-numad.m4             |  2 +-
m4/virt-result.m4            | 21 ++++++++++--
12 files changed, 93 insertions(+), 16 deletions(-)
create mode 100644 m4/virt-colours.m4

[libvirt] [PATCH 0/4] Colourize configure output

Posted by Michal Privoznik 24 weeks ago
An example how configure looks like with these changes applied:

https://travis-ci.org/zippy2/libvirt/jobs/582549099#L4247

Michal Prívozník (4):
  configure: Prefer LIBVIRT_RESULT over AC_MSG_NOTICE
  virt-result.m4: Align string more generously
  configure: Colorize output
  virt-result.m4: Colourize summary printings

 configure.ac                 |  8 ++---
 m4/virt-chrdev-lock-files.m4 |  2 +-
 m4/virt-colours.m4           | 62 ++++++++++++++++++++++++++++++++++++
 m4/virt-debug.m4             |  2 +-
 m4/virt-default-editor.m4    |  2 +-
 m4/virt-dtrace.m4            |  2 +-
 m4/virt-host-validate.m4     |  2 +-
 m4/virt-init-script.m4       |  2 +-
 m4/virt-loader-nvram.m4      |  2 +-
 m4/virt-login-shell.m4       |  2 +-
 m4/virt-numad.m4             |  2 +-
 m4/virt-result.m4            | 21 ++++++++++--
 12 files changed, 93 insertions(+), 16 deletions(-)
 create mode 100644 m4/virt-colours.m4

-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/4] Colourize configure output

Posted by Ján Tomko 24 weeks ago
On Mon, Sep 09, 2019 at 09:49:38AM +0200, Michal Privoznik wrote:
>An example how configure looks like with these changes applied:
>
>https://travis-ci.org/zippy2/libvirt/jobs/582549099#L4247
>
>Michal Prívozník (4):
>  configure: Prefer LIBVIRT_RESULT over AC_MSG_NOTICE
>  virt-result.m4: Align string more generously
>  configure: Colorize output

Why on earth would anyone want that?

Jano

>  virt-result.m4: Colourize summary printings
>
> configure.ac                 |  8 ++---
> m4/virt-chrdev-lock-files.m4 |  2 +-
> m4/virt-colours.m4           | 62 ++++++++++++++++++++++++++++++++++++
> m4/virt-debug.m4             |  2 +-
> m4/virt-default-editor.m4    |  2 +-
> m4/virt-dtrace.m4            |  2 +-
> m4/virt-host-validate.m4     |  2 +-
> m4/virt-init-script.m4       |  2 +-
> m4/virt-loader-nvram.m4      |  2 +-
> m4/virt-login-shell.m4       |  2 +-
> m4/virt-numad.m4             |  2 +-
> m4/virt-result.m4            | 21 ++++++++++--
> 12 files changed, 93 insertions(+), 16 deletions(-)
> create mode 100644 m4/virt-colours.m4
>
>-- 
>2.21.0
>
>--
>libvir-list mailing list
>libvir-list@redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/4] Colourize configure output

Posted by Cole Robinson 23 weeks ago
On 9/9/19 4:52 AM, Ján Tomko wrote:
> On Mon, Sep 09, 2019 at 09:49:38AM +0200, Michal Privoznik wrote:
>> An example how configure looks like with these changes applied:
>>
>> https://travis-ci.org/zippy2/libvirt/jobs/582549099#L4247
>>
>> Michal Prívozník (4):
>>  configure: Prefer LIBVIRT_RESULT over AC_MSG_NOTICE
>>  virt-result.m4: Align string more generously
>>  configure: Colorize output
> 
> Why on earth would anyone want that?
> 

If you have an objection, please just state it plainly. IMO if an
outsider looking in on libvir-list saw your comment they may conclude
this is an unwelcoming place

- Cole

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/4] Colourize configure output

Posted by Ján Tomko 22 weeks ago
On Wed, Sep 11, 2019 at 06:26:15PM -0400, Cole Robinson wrote:
>On 9/9/19 4:52 AM, Ján Tomko wrote:
>> On Mon, Sep 09, 2019 at 09:49:38AM +0200, Michal Privoznik wrote:
>>> An example how configure looks like with these changes applied:
>>>
>>> https://travis-ci.org/zippy2/libvirt/jobs/582549099#L4247
>>>
>>> Michal Prívozník (4):
>>>  configure: Prefer LIBVIRT_RESULT over AC_MSG_NOTICE
>>>  virt-result.m4: Align string more generously
>>>  configure: Colorize output
>>
>> Why on earth would anyone want that?
>>
>
>If you have an objection, please just state it plainly. IMO if an
>outsider looking in on libvir-list saw your comment they may conclude
>this is an unwelcoming place
>

My objection was aesthetical, sorry for not stating it as factually and
eloquently as Peter.

I'll try to spend more time on the messages in the future. (and
preferably after lunch)

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/4] Colourize configure output

Posted by Michal Privoznik 24 weeks ago
On 9/9/19 10:52 AM, Ján Tomko wrote:
> On Mon, Sep 09, 2019 at 09:49:38AM +0200, Michal Privoznik wrote:
>> An example how configure looks like with these changes applied:
>>
>> https://travis-ci.org/zippy2/libvirt/jobs/582549099#L4247
>>
>> Michal Prívozník (4):
>>  configure: Prefer LIBVIRT_RESULT over AC_MSG_NOTICE
>>  virt-result.m4: Align string more generously
>>  configure: Colorize output
> 
> Why on earth would anyone want that?

I find it easier to see at the first glance what features are enabled 
and what are disabled.

Also, the first two patches are independent of the feature, so even if 
we don't want to merge the rest, the first two still derserve review IMO.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list