qemu: Honor qemu's request to use all vCPU props

[libvirt] [PATCH 0/2] [for-5.7.0] qemu: Honor qemu's request to use all vCPU props

Peter Krempa posted 2 patches 4 years, 7 months ago

Download series mbox

Test syntax-check passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1567085889.git.pkrempa@redhat.com

src/qemu/qemu_command.c                       | 19 +++----------------
src/qemu/qemu_domain.c                        |  3 +++
src/qemu/qemu_domain.h                        |  3 +++
src/qemu/qemu_monitor.c                       |  2 ++
src/qemu/qemu_monitor.h                       |  6 ++++++
src/qemu/qemu_monitor_json.c                  |  4 ++++
.../x86-modern-bulk-monitor.json              |  8 ++++----
.../x86-modern-individual-add-monitor.json    |  4 ++--
8 files changed, 27 insertions(+), 22 deletions(-)

Expand all Fold all

[libvirt] [PATCH 0/2] [for-5.7.0] qemu: Honor qemu's request to use all vCPU props

Posted by Peter Krempa 4 years, 7 months ago

qemu documents that we should pass in all fields of
'CpuInstanceProperties' back when hotplugging cpus, but we didn't do
that. It turns out that qemu wanted to add new fields which were
mandatory and thus broke the interop with libvirt.

Let's honor their reques.

Peter Krempa (2):
  qemu: Extract and store vCPU properties as qemu returned them
  qemu: command: Use all vCPU properties when creating args for vCPU
    hotplug

 src/qemu/qemu_command.c                       | 19 +++----------------
 src/qemu/qemu_domain.c                        |  3 +++
 src/qemu/qemu_domain.h                        |  3 +++
 src/qemu/qemu_monitor.c                       |  2 ++
 src/qemu/qemu_monitor.h                       |  6 ++++++
 src/qemu/qemu_monitor_json.c                  |  4 ++++
 .../x86-modern-bulk-monitor.json              |  8 ++++----
 .../x86-modern-individual-add-monitor.json    |  4 ++--
 8 files changed, 27 insertions(+), 22 deletions(-)

-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/2] [for-5.7.0] qemu: Honor qemu's request to use all vCPU props

Posted by Ján Tomko 4 years, 7 months ago

On Thu, Aug 29, 2019 at 03:45:15PM +0200, Peter Krempa wrote:
>qemu documents that we should pass in all fields of
>'CpuInstanceProperties' back when hotplugging cpus, but we didn't do
>that. It turns out that qemu wanted to add new fields which were
>mandatory and thus broke the interop with libvirt.
>
>Let's honor their reques.
>

s/reques/request/

>Peter Krempa (2):
>  qemu: Extract and store vCPU properties as qemu returned them
>  qemu: command: Use all vCPU properties when creating args for vCPU
>    hotplug
>
> src/qemu/qemu_command.c                       | 19 +++----------------
> src/qemu/qemu_domain.c                        |  3 +++
> src/qemu/qemu_domain.h                        |  3 +++
> src/qemu/qemu_monitor.c                       |  2 ++
> src/qemu/qemu_monitor.h                       |  6 ++++++
> src/qemu/qemu_monitor_json.c                  |  4 ++++
> .../x86-modern-bulk-monitor.json              |  8 ++++----
> .../x86-modern-individual-add-monitor.json    |  4 ++--
> 8 files changed, 27 insertions(+), 22 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list