qemu_command: clean up more labels (virtio-fs epopee)

[libvirt] [PATCH 0/7] qemu_command: clean up more labels (virtio-fs epopee)

Ján Tomko posted 7 patches 4 years, 8 months ago

Download series mbox

Test syntax-check passed

Failed in applying to current master (apply log)

src/qemu/qemu_command.c | 87 ++++++++++++++++++-----------------------
src/qemu/qemu_command.h |  1 -
src/qemu/qemu_hotplug.c |  2 +-
3 files changed, 38 insertions(+), 52 deletions(-)

Expand all Fold all

[libvirt] [PATCH 0/7] qemu_command: clean up more labels (virtio-fs epopee)

Posted by Ján Tomko 4 years, 8 months ago

Ján Tomko (7):
  qemuBuildHostNetStr: remove unused cfg
  qemuBuildHostNetStr: remove unused 'driver' argument
  qemuBuildHostNetStr: remove unnecessary cleanup label
  qemuBuildSoundCommandLine: reduce scope of codecstr
  qemuBuildMemoryBackendProps: remove useless cleanup label
  qemuBuildMemoryBackendProps: use 'rc' instead of ret.
  qemuBuildMemoryCellBackendStr: remove useless ret variable

 src/qemu/qemu_command.c | 87 ++++++++++++++++++-----------------------
 src/qemu/qemu_command.h |  1 -
 src/qemu/qemu_hotplug.c |  2 +-
 3 files changed, 38 insertions(+), 52 deletions(-)

-- 
2.19.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/7] qemu_command: clean up more labels (virtio-fs epopee)

Posted by Cole Robinson 4 years, 7 months ago

On 8/26/19 4:44 PM, Ján Tomko wrote:
> Ján Tomko (7):
>   qemuBuildHostNetStr: remove unused cfg
>   qemuBuildHostNetStr: remove unused 'driver' argument
>   qemuBuildHostNetStr: remove unnecessary cleanup label
>   qemuBuildSoundCommandLine: reduce scope of codecstr
>   qemuBuildMemoryBackendProps: remove useless cleanup label
>   qemuBuildMemoryBackendProps: use 'rc' instead of ret.
>   qemuBuildMemoryCellBackendStr: remove useless ret variable
> 
>  src/qemu/qemu_command.c | 87 ++++++++++++++++++-----------------------
>  src/qemu/qemu_command.h |  1 -
>  src/qemu/qemu_hotplug.c |  2 +-
>  3 files changed, 38 insertions(+), 52 deletions(-)
> 

Patch #3 has some rebase conflicts after the slirp work, but they are
straight forward

Reviewed-by: Cole Robinson <crobinso@redhat.com>

- Cole

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list