conf: namespaces: remove some copy'n'paste

[libvirt] [PATCH 14/21] util: introduce virXMLNamespaceFormatNS

Posted by Ján Tomko 6 years, 5 months ago

A function to automatically format the xmlns:<prefix>='<uri>'
attribute for per-driver namespaces.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 src/util/virxml.c | 7 +++++++
 src/util/virxml.h | 4 ++++
 2 files changed, 11 insertions(+)

diff --git a/src/util/virxml.c b/src/util/virxml.c
index f55b9a362c..11b6031b09 100644
--- a/src/util/virxml.c
+++ b/src/util/virxml.c
@@ -1408,3 +1408,10 @@ virXPathContextNodeRestore(virXPathContextNodeSavePtr save)
 
     save->ctxt->node = save->node;
 }
+
+void
+virXMLNamespaceFormatNS(virBufferPtr buf,
+                        virXMLNamespace const *ns)
+{
+    virBufferAsprintf(buf, " xmlns:%s='%s'", ns->prefix, ns->href());
+}
diff --git a/src/util/virxml.h b/src/util/virxml.h
index ea0c3d3ab3..bcc10647b5 100644
--- a/src/util/virxml.h
+++ b/src/util/virxml.h
@@ -261,3 +261,7 @@ struct _virXMLNamespace {
 };
 typedef struct _virXMLNamespace virXMLNamespace;
 typedef virXMLNamespace *virXMLNamespacePtr;
+
+void
+virXMLNamespaceFormatNS(virBufferPtr buf,
+                        virXMLNamespace const *ns);
-- 
2.19.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 14/21] util: introduce virXMLNamespaceFormatNS

Posted by Jiri Denemark 6 years, 5 months ago

On Wed, Aug 21, 2019 at 01:15:36 +0200, Ján Tomko wrote:
> A function to automatically format the xmlns:<prefix>='<uri>'
> attribute for per-driver namespaces.
> 
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> ---
>  src/util/virxml.c | 7 +++++++
>  src/util/virxml.h | 4 ++++
>  2 files changed, 11 insertions(+)
> 
> diff --git a/src/util/virxml.c b/src/util/virxml.c
> index f55b9a362c..11b6031b09 100644
> --- a/src/util/virxml.c
> +++ b/src/util/virxml.c
> @@ -1408,3 +1408,10 @@ virXPathContextNodeRestore(virXPathContextNodeSavePtr save)
>  
>      save->ctxt->node = save->node;
>  }
> +

Two empty lines between functions, please.

> +void
> +virXMLNamespaceFormatNS(virBufferPtr buf,
> +                        virXMLNamespace const *ns)
> +{
> +    virBufferAsprintf(buf, " xmlns:%s='%s'", ns->prefix, ns->href());
> +}

Reviewed-by: Jiri Denemark <jdenemar@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list