Drop KVM assignment

[libvirt] [PATCH 05/12] virhostdev: Disable legacy kvm assignment

Posted by Michal Privoznik 6 years, 5 months ago

The KVM assignment is going to be removed shortly. Don't let the
hostdev module configure it.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 src/util/virhostdev.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/src/util/virhostdev.c b/src/util/virhostdev.c
index e3f48a9a2e..29e75ffc84 100644
--- a/src/util/virhostdev.c
+++ b/src/util/virhostdev.c
@@ -246,12 +246,16 @@ virHostdevGetPCIHostDevice(const virDomainHostdevDef *hostdev,
 
     virPCIDeviceSetManaged(actual, hostdev->managed);
 
-    if (pcisrc->backend == VIR_DOMAIN_HOSTDEV_PCI_BACKEND_VFIO)
+    if (pcisrc->backend == VIR_DOMAIN_HOSTDEV_PCI_BACKEND_VFIO) {
         virPCIDeviceSetStubDriver(actual, VIR_PCI_STUB_DRIVER_VFIO);
-    else if (pcisrc->backend == VIR_DOMAIN_HOSTDEV_PCI_BACKEND_XEN)
+    } else if (pcisrc->backend == VIR_DOMAIN_HOSTDEV_PCI_BACKEND_XEN) {
         virPCIDeviceSetStubDriver(actual, VIR_PCI_STUB_DRIVER_XEN);
-    else
-        virPCIDeviceSetStubDriver(actual, VIR_PCI_STUB_DRIVER_KVM);
+    } else {
+        virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
+                       _("pci backend driver '%s' is not supported"),
+                       virDomainHostdevSubsysPCIBackendTypeToString(pcisrc->backend));
+        return -1;
+    }
 
     VIR_STEAL_PTR(*pci, actual);
     return 0;
-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 05/12] virhostdev: Disable legacy kvm assignment

Posted by Daniel Henrique Barboza 6 years, 5 months ago


On 8/20/19 11:30 AM, Michal Privoznik wrote:
> The KVM assignment is going to be removed shortly. Don't let the
> hostdev module configure it.
>
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---


Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Tested-by: Daniel Henrique Barboza <danielhb413@gmail.com>


>   src/util/virhostdev.c | 12 ++++++++----
>   1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/src/util/virhostdev.c b/src/util/virhostdev.c
> index e3f48a9a2e..29e75ffc84 100644
> --- a/src/util/virhostdev.c
> +++ b/src/util/virhostdev.c
> @@ -246,12 +246,16 @@ virHostdevGetPCIHostDevice(const virDomainHostdevDef *hostdev,
>   
>       virPCIDeviceSetManaged(actual, hostdev->managed);
>   
> -    if (pcisrc->backend == VIR_DOMAIN_HOSTDEV_PCI_BACKEND_VFIO)
> +    if (pcisrc->backend == VIR_DOMAIN_HOSTDEV_PCI_BACKEND_VFIO) {
>           virPCIDeviceSetStubDriver(actual, VIR_PCI_STUB_DRIVER_VFIO);
> -    else if (pcisrc->backend == VIR_DOMAIN_HOSTDEV_PCI_BACKEND_XEN)
> +    } else if (pcisrc->backend == VIR_DOMAIN_HOSTDEV_PCI_BACKEND_XEN) {
>           virPCIDeviceSetStubDriver(actual, VIR_PCI_STUB_DRIVER_XEN);
> -    else
> -        virPCIDeviceSetStubDriver(actual, VIR_PCI_STUB_DRIVER_KVM);
> +    } else {
> +        virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
> +                       _("pci backend driver '%s' is not supported"),
> +                       virDomainHostdevSubsysPCIBackendTypeToString(pcisrc->backend));
> +        return -1;
> +    }
>   
>       VIR_STEAL_PTR(*pci, actual);
>       return 0;

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 05/12] virhostdev: Disable legacy kvm assignment

Posted by Ján Tomko 6 years, 5 months ago

On Tue, Aug 20, 2019 at 04:30:25PM +0200, Michal Privoznik wrote:
>The KVM assignment is going to be removed shortly. Don't let the
>hostdev module configure it.
>
>Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
>---
> src/util/virhostdev.c | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list