[libvirt] [RFC PATCH 0/2] qemu: Enable -blockdev [READ ME!] (blockdev-add saga finale?)

Peter Krempa posted 2 patches 13 weeks ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1565965810.git.pkrempa@redhat.com
src/qemu/qemu_capabilities.c                  |   5 +
src/qemu/qemu_capabilities.h                  |   1 +
.../caps_4.1.0.x86_64.xml                     |   2 +
.../controller-virtio-scsi.x86_64-latest.args |  35 +++--
.../disk-aio.x86_64-latest.args               |  19 ++-
...-backing-chains-noindex.x86_64-latest.args | 145 +++++++++++++++---
.../disk-cache.x86_64-latest.args             |  50 ++++--
.../disk-cdrom-network.x86_64-latest.args     |  32 ++--
.../disk-cdrom-tray.x86_64-latest.args        |  24 ++-
.../disk-cdrom.x86_64-latest.args             |  21 +--
.../disk-copy_on_read.x86_64-latest.args      |  19 ++-
.../disk-detect-zeroes.x86_64-latest.args     |  17 +-
.../disk-error-policy.x86_64-latest.args      |  30 ++--
.../disk-floppy-q35-2_11.x86_64-latest.args   |  14 +-
.../disk-floppy-q35-2_9.x86_64-latest.args    |  14 +-
.../disk-floppy.x86_64-latest.args            |  21 ++-
.../disk-network-gluster.x86_64-latest.args   |  32 ++--
.../disk-network-iscsi.x86_64-latest.args     |  58 ++++---
.../disk-network-nbd.x86_64-latest.args       |  41 +++--
.../disk-network-rbd.x86_64-latest.args       |  67 +++++---
.../disk-network-sheepdog.x86_64-latest.args  |  16 +-
...isk-network-source-auth.x86_64-latest.args |  30 ++--
.../disk-network-tlsx509.x86_64-latest.args   |  64 +++++---
.../disk-readonly-disk.x86_64-latest.args     |  14 +-
.../disk-scsi-device-auto.x86_64-latest.args  |  14 +-
.../disk-scsi.x86_64-latest.args              |  35 +++--
.../disk-shared.x86_64-latest.args            |  36 +++--
...irtio-scsi-reservations.x86_64-latest.args |  20 ++-
.../floppy-drive-fat.x86_64-latest.args       |   7 +-
...egl-headless-rendernode.x86_64-latest.args |   7 +-
.../graphics-egl-headless.x86_64-latest.args  |   7 +-
...threads-virtio-scsi-pci.x86_64-latest.args |  25 ++-
...y-hotplug-nvdimm-access.x86_64-latest.args |   7 +-
...ry-hotplug-nvdimm-align.x86_64-latest.args |   7 +-
...ry-hotplug-nvdimm-label.x86_64-latest.args |   7 +-
...ory-hotplug-nvdimm-pmem.x86_64-latest.args |   7 +-
...hotplug-nvdimm-readonly.x86_64-latest.args |   7 +-
.../memory-hotplug-nvdimm.x86_64-latest.args  |   7 +-
...eo-bochs-display-device.x86_64-latest.args |  10 +-
...virtio-non-transitional.x86_64-latest.args |   7 +-
.../virtio-transitional.x86_64-latest.args    |   7 +-
.../x86_64-pc-graphics.x86_64-latest.args     |   8 +-
.../x86_64-pc-headless.x86_64-latest.args     |   8 +-
.../x86_64-q35-graphics.x86_64-latest.args    |   8 +-
.../x86_64-q35-headless.x86_64-latest.args    |   8 +-
45 files changed, 714 insertions(+), 306 deletions(-)

[libvirt] [RFC PATCH 0/2] qemu: Enable -blockdev [READ ME!] (blockdev-add saga finale?)

Posted by Peter Krempa 13 weeks ago
With the patches I've posted to the list libvirt should be mostly
prepared to use -blockdev instead of -drive to specify disk images.

There's one gothcha though. Internal snapshots don't work due to qemu
considering every monitor-owned node for snapshot as well. With blockdev
everything became monitor-owned including the 'file' nodes which are
definitely not snapshottable. Even when qemu fixes that bug I don't
think it will be introspectable.

Our options are either to wait for the qemu fix and then try to detect
it somehow, perhaps as a version check (yuck), or go ahead and inform
users to upgrade to a newer qemu afterwards.

Any other ideas or suggestions?

Peter Krempa (2):
  qemu: caps: Add capability for dynamic 'auto-read-only' support for
    files
  qemu: enable blockdev support

 src/qemu/qemu_capabilities.c                  |   5 +
 src/qemu/qemu_capabilities.h                  |   1 +
 .../caps_4.1.0.x86_64.xml                     |   2 +
 .../controller-virtio-scsi.x86_64-latest.args |  35 +++--
 .../disk-aio.x86_64-latest.args               |  19 ++-
 ...-backing-chains-noindex.x86_64-latest.args | 145 +++++++++++++++---
 .../disk-cache.x86_64-latest.args             |  50 ++++--
 .../disk-cdrom-network.x86_64-latest.args     |  32 ++--
 .../disk-cdrom-tray.x86_64-latest.args        |  24 ++-
 .../disk-cdrom.x86_64-latest.args             |  21 +--
 .../disk-copy_on_read.x86_64-latest.args      |  19 ++-
 .../disk-detect-zeroes.x86_64-latest.args     |  17 +-
 .../disk-error-policy.x86_64-latest.args      |  30 ++--
 .../disk-floppy-q35-2_11.x86_64-latest.args   |  14 +-
 .../disk-floppy-q35-2_9.x86_64-latest.args    |  14 +-
 .../disk-floppy.x86_64-latest.args            |  21 ++-
 .../disk-network-gluster.x86_64-latest.args   |  32 ++--
 .../disk-network-iscsi.x86_64-latest.args     |  58 ++++---
 .../disk-network-nbd.x86_64-latest.args       |  41 +++--
 .../disk-network-rbd.x86_64-latest.args       |  67 +++++---
 .../disk-network-sheepdog.x86_64-latest.args  |  16 +-
 ...isk-network-source-auth.x86_64-latest.args |  30 ++--
 .../disk-network-tlsx509.x86_64-latest.args   |  64 +++++---
 .../disk-readonly-disk.x86_64-latest.args     |  14 +-
 .../disk-scsi-device-auto.x86_64-latest.args  |  14 +-
 .../disk-scsi.x86_64-latest.args              |  35 +++--
 .../disk-shared.x86_64-latest.args            |  36 +++--
 ...irtio-scsi-reservations.x86_64-latest.args |  20 ++-
 .../floppy-drive-fat.x86_64-latest.args       |   7 +-
 ...egl-headless-rendernode.x86_64-latest.args |   7 +-
 .../graphics-egl-headless.x86_64-latest.args  |   7 +-
 ...threads-virtio-scsi-pci.x86_64-latest.args |  25 ++-
 ...y-hotplug-nvdimm-access.x86_64-latest.args |   7 +-
 ...ry-hotplug-nvdimm-align.x86_64-latest.args |   7 +-
 ...ry-hotplug-nvdimm-label.x86_64-latest.args |   7 +-
 ...ory-hotplug-nvdimm-pmem.x86_64-latest.args |   7 +-
 ...hotplug-nvdimm-readonly.x86_64-latest.args |   7 +-
 .../memory-hotplug-nvdimm.x86_64-latest.args  |   7 +-
 ...eo-bochs-display-device.x86_64-latest.args |  10 +-
 ...virtio-non-transitional.x86_64-latest.args |   7 +-
 .../virtio-transitional.x86_64-latest.args    |   7 +-
 .../x86_64-pc-graphics.x86_64-latest.args     |   8 +-
 .../x86_64-pc-headless.x86_64-latest.args     |   8 +-
 .../x86_64-q35-graphics.x86_64-latest.args    |   8 +-
 .../x86_64-q35-headless.x86_64-latest.args    |   8 +-
 45 files changed, 714 insertions(+), 306 deletions(-)

-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list