[libvirt] [PATCH v2 0/2] Revert "configure: Remove --enable-test-coverage"

Jiri Denemark posted 2 patches 13 weeks ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1565711022.git.jdenemar@redhat.com
Makefile.am                | 20 +++++++++++++++++---
configure.ac               | 18 ++++++++++++++++++
docs/hacking.html.in       | 29 -----------------------------
src/Makefile.am            |  2 ++
src/remote/Makefile.inc.am |  2 ++
tests/Makefile.am          |  2 ++
tools/Makefile.am          |  6 ++++++
7 files changed, 47 insertions(+), 32 deletions(-)

[libvirt] [PATCH v2 0/2] Revert "configure: Remove --enable-test-coverage"

Posted by Jiri Denemark 13 weeks ago
Gnulib's make coverage (or init-coverage, build-coverage, gen-coverage)
is not a 1-1 replacement for the original configure option. Our old
--enable-test-coverage seems to be close to gnulib's make build-coverage
except gnulib runs lcov in that phase and the build actually fails for
me even before lcov is run. And since we want to be able to just build
libvirt without running lcov, I suggest reverting to our own
implementation.

I admit the best solution would be to somehow make gnulib support what
we need (and fix the actual build), but I don't feel brave enough to do
that. Eric? :-)

Also if we ever switch to glib and drop gnulib completely, we would need
to reintroduce our own implementation anyway.

I had to do some changes to resolve conflicts. The changes were not too
big, but I figured I'd rather resend this patch especially when I
originally forgot to Cc the original author of the reverted patch.

Jiri Denemark (2):
  Revert "configure: Remove --enable-test-coverage"
  Revert "docs: hacking: Add 'Code coverage reports' section"

 Makefile.am                | 20 +++++++++++++++++---
 configure.ac               | 18 ++++++++++++++++++
 docs/hacking.html.in       | 29 -----------------------------
 src/Makefile.am            |  2 ++
 src/remote/Makefile.inc.am |  2 ++
 tests/Makefile.am          |  2 ++
 tools/Makefile.am          |  6 ++++++
 7 files changed, 47 insertions(+), 32 deletions(-)

-- 
2.22.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 0/2] Revert "configure: Remove --enable-test-coverage"

Posted by Eric Blake 13 weeks ago
On 8/13/19 10:49 AM, Jiri Denemark wrote:
> Gnulib's make coverage (or init-coverage, build-coverage, gen-coverage)
> is not a 1-1 replacement for the original configure option. Our old
> --enable-test-coverage seems to be close to gnulib's make build-coverage
> except gnulib runs lcov in that phase and the build actually fails for
> me even before lcov is run. And since we want to be able to just build
> libvirt without running lcov, I suggest reverting to our own
> implementation.
> 
> I admit the best solution would be to somehow make gnulib support what
> we need (and fix the actual build), but I don't feel brave enough to do
> that. Eric? :-)

There, it's probably better to ask the bug-gnulib list (rather than just
me), to possibly widen the set of developers that could actually make
those sort of changes.

> 
> Also if we ever switch to glib and drop gnulib completely, we would need
> to reintroduce our own implementation anyway.

True.

> 
> I had to do some changes to resolve conflicts. The changes were not too
> big, but I figured I'd rather resend this patch especially when I
> originally forgot to Cc the original author of the reverted patch.
> 
> Jiri Denemark (2):
>   Revert "configure: Remove --enable-test-coverage"
>   Revert "docs: hacking: Add 'Code coverage reports' section"
> 

ACK series

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list