util: open pci config read-only for querying

[libvirt] [PATCH 0/5] util: open pci config read-only for querying

Ján Tomko posted 5 patches 4 years, 8 months ago

Download series mbox

Test syntax-check passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1565703264.git.jtomko@redhat.com

src/util/virpci.c | 40 +++++++++++++++++++++++++++++-----------
1 file changed, 29 insertions(+), 11 deletions(-)

Expand all Fold all

[libvirt] [PATCH 0/5] util: open pci config read-only for querying

Posted by Ján Tomko 4 years, 8 months ago

A bunch of functions opened the PCI device config as read-write
even though they only read from it.

Ján Tomko (5):
  util: introduce virPCIDeviceConfigOpenInternal
  util: Introduce virPCIDeviceConfigOpenWrite
  util: introduce readonly attribute to virPCIDeviceConfigOpenInternal
  util: introduce virPCIDeviceConfigOpenTry
  util: default to read-only in virPCIDeviceConfigOpen

 src/util/virpci.c | 40 +++++++++++++++++++++++++++++-----------
 1 file changed, 29 insertions(+), 11 deletions(-)

-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/5] util: open pci config read-only for querying

Posted by Michal Privoznik 4 years, 8 months ago

On 8/13/19 3:45 PM, Ján Tomko wrote:
> A bunch of functions opened the PCI device config as read-write
> even though they only read from it.
> 
> Ján Tomko (5):
>    util: introduce virPCIDeviceConfigOpenInternal
>    util: Introduce virPCIDeviceConfigOpenWrite
>    util: introduce readonly attribute to virPCIDeviceConfigOpenInternal
>    util: introduce virPCIDeviceConfigOpenTry
>    util: default to read-only in virPCIDeviceConfigOpen
> 
>   src/util/virpci.c | 40 +++++++++++++++++++++++++++++-----------
>   1 file changed, 29 insertions(+), 11 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list