qemu: Add blockdev support for block copy (blockdev-add saga)

[libvirt] [PATCH 07/12] qemu: domain: Add 'break' after formatting commit job status XML

Posted by Peter Krempa 6 years, 6 months ago

In commit 3f93884a4d0 where the job handling of commit jobs with
blockdev was added I've forgot to add a 'break' in the switch fomatting
the status XML. Thankfully this would not be a problem as the cases
where this fell through didn't have any code.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/qemu/qemu_domain.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 50dc4f3764..2e722f4ee4 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -2410,6 +2410,8 @@ qemuDomainObjPrivateXMLFormatBlockjobIterator(void *payload,
                 virBufferAsprintf(&childBuf, "<top node='%s'/>\n", job->data.commit.top->nodeformat);
             if (job->data.commit.topparent)
                 virBufferAsprintf(&childBuf, "<topparent node='%s'/>\n", job->data.commit.topparent->nodeformat);
+            break;
+
         case QEMU_BLOCKJOB_TYPE_COPY:
         case QEMU_BLOCKJOB_TYPE_NONE:
         case QEMU_BLOCKJOB_TYPE_INTERNAL:
-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 07/12] qemu: domain: Add 'break' after formatting commit job status XML

Posted by Ján Tomko 6 years, 6 months ago

On Thu, Aug 08, 2019 at 06:00:37PM +0200, Peter Krempa wrote:
>In commit 3f93884a4d0 where the job handling of commit jobs with
>blockdev was added I've forgot to add a 'break' in the switch fomatting
>the status XML. Thankfully this would not be a problem as the cases
>where this fell through didn't have any code.
>
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> src/qemu/qemu_domain.c | 2 ++
> 1 file changed, 2 insertions(+)

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list