Fix hyperv and kvm features with QEMU 4.1

[libvirt] [PATCH 0/5] Fix hyperv and kvm features with QEMU 4.1

Posted by Jiri Denemark 4 years, 8 months ago

Originally the names of the hyperv and kvm CPU features were only used
internally for looking up their CPUID bits. But with QEMU 4.1 we check
which features were enabled or disabled by a freshly started QEMU
process using their names rather than their CPUID bits (mostly because
of MSR features). Thus we need to change our made up internal names into
the actual names used by QEMU.

Otherwise libvirt would mistakenly report the features as unavailable
and refuse to start any domain using them with QEMU 4.1.

Reported-by: Vitaly Kuznetsov <vkuznets@redhat.com>

Jiri Denemark (5):
  qemu: Fix hyperv features with QEMU 4.1
  qemu: Prefer dashes for hyperv features
  cpu: Drop KVM_ from hyperv feature macros
  cpu: Drop unused KVM features
  qemu: Fix KVM features with QEMU 4.1

 src/cpu/cpu_x86.c                             | 77 +++++++------------
 src/cpu/cpu_x86_data.h                        | 38 ++++-----
 src/qemu/qemu_command.c                       | 19 +++--
 src/qemu/qemu_process.c                       |  2 +-
 .../clock-timer-hyperv-rtc.args               |  2 +-
 tests/qemuxml2argvdata/hyperv-panic.args      |  2 +-
 tests/qemuxml2argvdata/hyperv.args            |  4 +-
 tests/qemuxml2argvdata/panic-double.args      |  2 +-
 8 files changed, 61 insertions(+), 85 deletions(-)

-- 
2.22.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/5] Fix hyperv and kvm features with QEMU 4.1

Posted by Ján Tomko 4 years, 8 months ago

On Fri, Jul 26, 2019 at 05:30:51PM +0200, Jiri Denemark wrote:
>Originally the names of the hyperv and kvm CPU features were only used
>internally for looking up their CPUID bits. But with QEMU 4.1 we check
>which features were enabled or disabled by a freshly started QEMU
>process using their names rather than their CPUID bits (mostly because
>of MSR features). Thus we need to change our made up internal names into
>the actual names used by QEMU.
>
>Otherwise libvirt would mistakenly report the features as unavailable
>and refuse to start any domain using them with QEMU 4.1.
>
>Reported-by: Vitaly Kuznetsov <vkuznets@redhat.com>
>
>Jiri Denemark (5):
>  qemu: Fix hyperv features with QEMU 4.1
>  qemu: Prefer dashes for hyperv features
>  cpu: Drop KVM_ from hyperv feature macros
>  cpu: Drop unused KVM features
>  qemu: Fix KVM features with QEMU 4.1
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/5] Fix hyperv and kvm features with QEMU 4.1

Posted by Vitaly Kuznetsov 4 years, 8 months ago

Jiri Denemark <jdenemar@redhat.com> writes:

> Originally the names of the hyperv and kvm CPU features were only used
> internally for looking up their CPUID bits. But with QEMU 4.1 we check
> which features were enabled or disabled by a freshly started QEMU
> process using their names rather than their CPUID bits (mostly because
> of MSR features). Thus we need to change our made up internal names into
> the actual names used by QEMU.
>
> Otherwise libvirt would mistakenly report the features as unavailable
> and refuse to start any domain using them with QEMU 4.1.
>
> Reported-by: Vitaly Kuznetsov <vkuznets@redhat.com>
>

It seems to resolve my issue, so

Tested-by: Vitaly Kuznetsov <vkuznets@redhat.com>

I'll rebase my 'direct stimer' on top of this, thanks!

-- 
Vitaly

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list