[libvirt] [PATCH 1/3] virsh: clean up includes

Ján Tomko posted 3 patches 6 years, 6 months ago
[libvirt] [PATCH 1/3] virsh: clean up includes
Posted by Ján Tomko 6 years, 6 months ago
We don't need domain_conf or libvirt-{qemu,lxc} in these generic files.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 tools/virsh.c | 3 ---
 tools/vsh.c   | 3 ---
 2 files changed, 6 deletions(-)

diff --git a/tools/virsh.c b/tools/virsh.c
index b41304a888..c758e38cbd 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -40,12 +40,9 @@
 #include "virerror.h"
 #include "virbuffer.h"
 #include "viralloc.h"
-#include <libvirt/libvirt-qemu.h>
-#include <libvirt/libvirt-lxc.h>
 #include "virfile.h"
 #include "virthread.h"
 #include "vircommand.h"
-#include "conf/domain_conf.h"
 #include "virtypedparam.h"
 #include "virstring.h"
 #include "virgettext.h"
diff --git a/tools/vsh.c b/tools/vsh.c
index f2486498c9..5de082cb34 100644
--- a/tools/vsh.c
+++ b/tools/vsh.c
@@ -41,12 +41,9 @@
 #include "virerror.h"
 #include "virbuffer.h"
 #include "viralloc.h"
-#include <libvirt/libvirt-qemu.h>
-#include <libvirt/libvirt-lxc.h>
 #include "virfile.h"
 #include "virthread.h"
 #include "vircommand.h"
-#include "conf/domain_conf.h"
 #include "virtypedparam.h"
 #include "virstring.h"
 
-- 
2.19.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 1/3] virsh: clean up includes
Posted by Peter Krempa 6 years, 6 months ago
On Thu, Jul 25, 2019 at 14:09:10 +0200, Ján Tomko wrote:
> We don't need domain_conf or libvirt-{qemu,lxc} in these generic files.
> 
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> ---
>  tools/virsh.c | 3 ---
>  tools/vsh.c   | 3 ---
>  2 files changed, 6 deletions(-)

ACK
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list