qemu: Fix handling of block job data in event handlers (blockdev-add saga fixes)

[libvirt] [PATCH 0/3] qemu: Fix handling of block job data in event handlers (blockdev-add saga fixes)

Peter Krempa posted 3 patches 4 years, 9 months ago

Download series mbox

Test syntax-check passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1563466802.git.pkrempa@redhat.com

src/qemu/qemu_driver.c  | 4 ++--
src/qemu/qemu_process.c | 3 +--
2 files changed, 3 insertions(+), 4 deletions(-)

Expand all Fold all

[libvirt] [PATCH 0/3] qemu: Fix handling of block job data in event handlers (blockdev-add saga fixes)

Posted by Peter Krempa 4 years, 9 months ago

Some of the refactors which allowed carrying more data with blockjobs
created a race condition when a too-quick job would actually delete the
data. This is a problem for legacy block jobs only.

Peter Krempa (3):
  qemu: process: Don't use qemuBlockJobStartupFinalize in
    qemuProcessHandleBlockJob
  qemu: driver: Don't use qemuBlockJobStartupFinalize in
    processBlockJobEvent
  qemu: driver: Add debug message when we conjure block job data object

 src/qemu/qemu_driver.c  | 4 ++--
 src/qemu/qemu_process.c | 3 +--
 2 files changed, 3 insertions(+), 4 deletions(-)

-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/3] qemu: Fix handling of block job data in event handlers (blockdev-add saga fixes)

Posted by Ján Tomko 4 years, 9 months ago

On Thu, Jul 18, 2019 at 06:22:05PM +0200, Peter Krempa wrote:
>Some of the refactors which allowed carrying more data with blockjobs
>created a race condition when a too-quick job would actually delete the
>data. This is a problem for legacy block jobs only.
>
>Peter Krempa (3):
>  qemu: process: Don't use qemuBlockJobStartupFinalize in
>    qemuProcessHandleBlockJob
>  qemu: driver: Don't use qemuBlockJobStartupFinalize in
>    processBlockJobEvent
>  qemu: driver: Add debug message when we conjure block job data object
>
> src/qemu/qemu_driver.c  | 4 ++--
> src/qemu/qemu_process.c | 3 +--
> 2 files changed, 3 insertions(+), 4 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list