[libvirt] [PATCH 2/2] docs: news: add per-release links

Ján Tomko posted 2 patches 6 years, 6 months ago
[libvirt] [PATCH 2/2] docs: news: add per-release links
Posted by Ján Tomko 6 years, 6 months ago
Wrap each release headline in an <a> element with the id set
to the release value and page.xsl will take care of the rest.

Reported-by: Kashyap Chamarthy <kchamart@redhat.com>
Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 docs/news-html.xsl | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/docs/news-html.xsl b/docs/news-html.xsl
index 6763a71fa3..5ca78d9578 100644
--- a/docs/news-html.xsl
+++ b/docs/news-html.xsl
@@ -41,12 +41,17 @@
   <!-- Release -->
   <xsl:template match="release">
     <h3>
-      <strong>
-        <xsl:value-of select="@version"/>
-        <xsl:text> (</xsl:text>
-        <xsl:value-of select="@date"/>
-        <xsl:text>)</xsl:text>
-      </strong>
+      <a>
+        <xsl:attribute name="id">
+          <xsl:value-of select="@version"/>
+        </xsl:attribute>
+        <strong>
+          <xsl:value-of select="@version"/>
+          <xsl:text> (</xsl:text>
+          <xsl:value-of select="@date"/>
+          <xsl:text>)</xsl:text>
+        </strong>
+      </a>
     </h3>
     <ul>
       <xsl:apply-templates select="section"/>
-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 2/2] docs: news: add per-release links
Posted by Andrea Bolognani 6 years, 6 months ago
On Wed, 2019-07-17 at 16:37 +0200, Ján Tomko wrote:
> Wrap each release headline in an <a> element with the id set
> to the release value and page.xsl will take care of the rest.
> 
> Reported-by: Kashyap Chamarthy <kchamart@redhat.com>
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> ---
>  docs/news-html.xsl | 17 +++++++++++------
>  1 file changed, 11 insertions(+), 6 deletions(-)

Neat! :)

Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 2/2] docs: news: add per-release links
Posted by Kashyap Chamarthy 6 years, 6 months ago
On Wed, Jul 17, 2019 at 04:37:07PM +0200, Ján Tomko wrote:
> Wrap each release headline in an <a> element with the id set
> to the release value and page.xsl will take care of the rest.
> 
> Reported-by: Kashyap Chamarthy <kchamart@redhat.com>
> Signed-off-by: Ján Tomko <jtomko@redhat.com>

Thanks for the quick patch!

Just tested this locally.  Works for me.  FWIW:

    Tested-by: Kashyap Chamarthy >kchamart@redhat.com>

> ---
>  docs/news-html.xsl | 17 +++++++++++------
>  1 file changed, 11 insertions(+), 6 deletions(-)

[...]

-- 
/kashyap

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list