qemu: Properly track blockjobs (blockdev-add saga)

[libvirt] [PATCH 09/25] qemu: blockjob: Add flag for invalid block job data

Posted by Peter Krempa 6 years, 7 months ago

The job data saved in the XML may be partially invalid e.g. if something
is missing. To prevent losing a domain with such a job add a flag to the
job data so that job APIs can ignore such a job and we can just cancel
it.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/qemu/qemu_blockjob.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/qemu/qemu_blockjob.h b/src/qemu/qemu_blockjob.h
index fe16badbc8..5b3af69d89 100644
--- a/src/qemu/qemu_blockjob.h
+++ b/src/qemu/qemu_blockjob.h
@@ -80,6 +80,8 @@ struct _qemuBlockJobData {
     bool synchronous; /* API call is waiting for this job */

     int newstate; /* qemuBlockjobState, subset of events emitted by qemu */
+
+    bool invalidData; /* the job data (except name) is not valid */
 };

 int
-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 09/25] qemu: blockjob: Add flag for invalid block job data

Posted by Ján Tomko 6 years, 6 months ago

On Fri, Jul 12, 2019 at 06:05:50PM +0200, Peter Krempa wrote:
>The job data saved in the XML may be partially invalid e.g. if something
>is missing. To prevent losing a domain with such a job add a flag to the
>job data so that job APIs can ignore such a job and we can just cancel
>it.
>
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> src/qemu/qemu_blockjob.h | 2 ++
> 1 file changed, 2 insertions(+)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list